[2/3] Add some new PE_IMAGE_DEBUG_TYPE values

Message ID 20200121155212.12686-3-jon.turney@dronecode.org.uk
State New
Headers show
Series
  • Identify reproducible build PE files in 'objdump -p'
Related show

Commit Message

Jon Turney Jan. 21, 2020, 3:52 p.m.
IMAGE_DEBUG_TYPE_REPRO is defined in the latest version of the PE
specification [1]. The others are defined in Windows SDK headers and/or
reported by DUMPBIN.

[1] https://docs.microsoft.com/en-us/windows/win32/debug/pe-format

bfd/ChangeLog:

2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>

	* peXXigen.c (debug_type_names): Add names for new debug data type
	values.

include/ChangeLog:

2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>

	* coff/internal.h (PE_IMAGE_DEBUG_TYPE_VC_FEATURE)
	(PE_IMAGE_DEBUG_TYPE_POGO, PE_IMAGE_DEBUG_TYPE_ILTCG)
	(PE_IMAGE_DEBUG_TYPE_MPX, PE_IMAGE_DEBUG_TYPE_REPRO): Add.
---
 bfd/ChangeLog           | 5 +++++
 bfd/peXXigen.c          | 7 ++++++-
 include/ChangeLog       | 6 ++++++
 include/coff/internal.h | 5 +++++
 4 files changed, 22 insertions(+), 1 deletion(-)

-- 
2.21.0

Comments

Alan Modra Jan. 28, 2020, 10:11 p.m. | #1
On Tue, Jan 21, 2020 at 03:52:11PM +0000, Jon Turney wrote:
> IMAGE_DEBUG_TYPE_REPRO is defined in the latest version of the PE

> specification [1]. The others are defined in Windows SDK headers and/or

> reported by DUMPBIN.

> 

> [1] https://docs.microsoft.com/en-us/windows/win32/debug/pe-format

> 

> bfd/ChangeLog:

> 

> 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>

> 

> 	* peXXigen.c (debug_type_names): Add names for new debug data type

> 	values.

> 

> include/ChangeLog:

> 

> 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>

> 

> 	* coff/internal.h (PE_IMAGE_DEBUG_TYPE_VC_FEATURE)

> 	(PE_IMAGE_DEBUG_TYPE_POGO, PE_IMAGE_DEBUG_TYPE_ILTCG)

> 	(PE_IMAGE_DEBUG_TYPE_MPX, PE_IMAGE_DEBUG_TYPE_REPRO): Add.


OK.

-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c
index ac0cf17464..dc7951f8d9 100644
--- a/bfd/peXXigen.c
+++ b/bfd/peXXigen.c
@@ -2603,7 +2603,7 @@  rsrc_print_section (bfd * abfd, void * vfile)
   return TRUE;
 }
 
-#define IMAGE_NUMBEROF_DEBUG_TYPES 12
+#define IMAGE_NUMBEROF_DEBUG_TYPES 17
 
 static char * debug_type_names[IMAGE_NUMBEROF_DEBUG_TYPES] =
 {
@@ -2619,6 +2619,11 @@  static char * debug_type_names[IMAGE_NUMBEROF_DEBUG_TYPES] =
   "Borland",
   "Reserved",
   "CLSID",
+  "Feature",
+  "CoffGrp",
+  "ILTCG",
+  "MPX",
+  "Repro",
 };
 
 static bfd_boolean
diff --git a/include/coff/internal.h b/include/coff/internal.h
index 24ac1dc75c..cbeb0160f6 100644
--- a/include/coff/internal.h
+++ b/include/coff/internal.h
@@ -157,6 +157,11 @@  struct internal_IMAGE_DEBUG_DIRECTORY
 #define PE_IMAGE_DEBUG_TYPE_BORLAND          9
 #define PE_IMAGE_DEBUG_TYPE_RESERVED10       10
 #define PE_IMAGE_DEBUG_TYPE_CLSID            11
+#define PE_IMAGE_DEBUG_TYPE_VC_FEATURE       12
+#define PE_IMAGE_DEBUG_TYPE_POGO             13
+#define PE_IMAGE_DEBUG_TYPE_ILTCG            14
+#define PE_IMAGE_DEBUG_TYPE_MPX              15
+#define PE_IMAGE_DEBUG_TYPE_REPRO            16
 
 /* Extra structure for a codeview debug record */
 #define CV_INFO_SIGNATURE_LENGTH 16