[1/3] Fix tspeed test case: copy libinproctrace to target

Message ID 1521043903-18837-2-git-send-email-arnez@linux.vnet.ibm.com
State New
Headers show
Series
  • Some gdbserver test suite fixes
Related show

Commit Message

Andreas Arnez March 14, 2018, 4:11 p.m.
The tspeed test case does not execute correctly because libinproctrace.so
is not copied to the target.  This is fixed.

gdb/testsuite/ChangeLog:

	* gdb.trace/tspeed.exp: Add invocation of gdb_load_shlib to ensure
	that libinproctrace is copied to the target.
---
 gdb/testsuite/gdb.trace/tspeed.exp | 1 +
 1 file changed, 1 insertion(+)

-- 
2.14.3

Comments

Simon Marchi March 15, 2018, 9:40 p.m. | #1
On 2018-03-14 12:11 PM, Andreas Arnez wrote:
> The tspeed test case does not execute correctly because libinproctrace.so

> is not copied to the target.  This is fixed.

> 

> gdb/testsuite/ChangeLog:

> 

> 	* gdb.trace/tspeed.exp: Add invocation of gdb_load_shlib to ensure

> 	that libinproctrace is copied to the target.

> ---

>  gdb/testsuite/gdb.trace/tspeed.exp | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp

> index d53608c51b..ecd36d2d9b 100644

> --- a/gdb/testsuite/gdb.trace/tspeed.exp

> +++ b/gdb/testsuite/gdb.trace/tspeed.exp

> @@ -19,6 +19,7 @@ standard_testfile

>  set executable $testfile

>  

>  set ipalib [get_in_proc_agent]

> +gdb_load_shlib $ipalib

>  

>  if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \

>  	  executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } {

> 


LGTM.

Simon
Andreas Arnez March 16, 2018, 7:41 p.m. | #2
On Thu, Mar 15 2018, Simon Marchi wrote:

> On 2018-03-14 12:11 PM, Andreas Arnez wrote:

>> The tspeed test case does not execute correctly because libinproctrace.so

>> is not copied to the target.  This is fixed.

>> 

>> gdb/testsuite/ChangeLog:

>> 

>> 	* gdb.trace/tspeed.exp: Add invocation of gdb_load_shlib to ensure

>> 	that libinproctrace is copied to the target.

>> ---

>>  gdb/testsuite/gdb.trace/tspeed.exp | 1 +

>>  1 file changed, 1 insertion(+)

>> 

>> diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp

>> index d53608c51b..ecd36d2d9b 100644

>> --- a/gdb/testsuite/gdb.trace/tspeed.exp

>> +++ b/gdb/testsuite/gdb.trace/tspeed.exp

>> @@ -19,6 +19,7 @@ standard_testfile

>>  set executable $testfile

>>  

>>  set ipalib [get_in_proc_agent]

>> +gdb_load_shlib $ipalib

>>  

>>  if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \

>>  	  executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } {

>> 

>

> LGTM.


Thanks, pushed.

--
Andreas

Patch

diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp
index d53608c51b..ecd36d2d9b 100644
--- a/gdb/testsuite/gdb.trace/tspeed.exp
+++ b/gdb/testsuite/gdb.trace/tspeed.exp
@@ -19,6 +19,7 @@  standard_testfile
 set executable $testfile
 
 set ipalib [get_in_proc_agent]
+gdb_load_shlib $ipalib
 
 if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
 	  executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } {