[ARM] : Fix the failing ACLE testcase with correct test directive.

Message ID DBBPR08MB4775E49B8BA773FFAAF2F8849B4E0@DBBPR08MB4775.eurprd08.prod.outlook.com
State New
Headers show
Series
  • [ARM] : Fix the failing ACLE testcase with correct test directive.
Related show

Commit Message

Srinath Parvathaneni Nov. 21, 2019, 4:32 p.m.
Hello,

This patch fixes arm acle testcase crc_hf_1.c by modifying the compiler options directive.

Regression tested on arm-none-eabi and found no regressions.

Ok for trunk? If ok, please commit on my behalf, I don't have the commit rights.

Thanks,
Srinath.

gcc/testsuite/ChangeLog:

2019-11-21  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

	* gcc.target/arm/acle/crc_hf_1.c: Modify the compiler options directive from
	dg-options to dg-additional-options.



###############     Attachment also inlined for ease of reply    ###############
diff --git a/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c b/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c
index e6cbfc0b33e56e4275b96978ca1823d7682792fb..f1de2bdffee41a0f3259e2bf00296e9c3218f548 100644
--- a/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c
+++ b/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c
@@ -3,7 +3,7 @@
 
 /* { dg-do compile } */
 /* { dg-require-effective-target arm_hard_vfp_ok }  */
-/* { dg-options "-mfloat-abi=hard -march=armv8-a+simd+crc" } */
+/* { dg-additional-options "-mfloat-abi=hard -march=armv8-a+simd+crc" } */
 
 #include <arm_acle.h>

Comments

Kyrill Tkachov Nov. 21, 2019, 6:06 p.m. | #1
Hi Srinath,

On 11/21/19 4:32 PM, Srinath Parvathaneni wrote:
> Hello,

>

> This patch fixes arm acle testcase crc_hf_1.c by modifying the 

> compiler options directive.

>

> Regression tested on arm-none-eabi and found no regressions.

>

> Ok for trunk? If ok, please commit on my behalf, I don't have the 

> commit rights.

>

This is ok.

I see Matthew has already committed it, which is fine. It's an obvious 
patch.

Thanks,

Kyrill


> Thanks,

> Srinath.

>

> gcc/testsuite/ChangeLog:

>

> 2019-11-21  Srinath Parvathaneni <srinath.parvathaneni@arm.com>

>

>         * gcc.target/arm/acle/crc_hf_1.c: Modify the compiler options 

> directive from

>         dg-options to dg-additional-options.

>

>

>

> ###############     Attachment also inlined for ease of reply    

> ###############

>

>

> diff --git a/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c 

> b/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c

> index 

> e6cbfc0b33e56e4275b96978ca1823d7682792fb..f1de2bdffee41a0f3259e2bf00296e9c3218f548 

> 100644

> --- a/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c

> +++ b/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c

> @@ -3,7 +3,7 @@

>

>  /* { dg-do compile } */

>  /* { dg-require-effective-target arm_hard_vfp_ok }  */

> -/* { dg-options "-mfloat-abi=hard -march=armv8-a+simd+crc" } */

> +/* { dg-additional-options "-mfloat-abi=hard -march=armv8-a+simd+crc" 

> } */

>

>  #include <arm_acle.h>

>

>

Patch

diff --git a/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c b/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c
index e6cbfc0b33e56e4275b96978ca1823d7682792fb..f1de2bdffee41a0f3259e2bf00296e9c3218f548 100644
--- a/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c
+++ b/gcc/testsuite/gcc.target/arm/acle/crc_hf_1.c
@@ -3,7 +3,7 @@ 
 
 /* { dg-do compile } */
 /* { dg-require-effective-target arm_hard_vfp_ok }  */
-/* { dg-options "-mfloat-abi=hard -march=armv8-a+simd+crc" } */
+/* { dg-additional-options "-mfloat-abi=hard -march=armv8-a+simd+crc" } */
 
 #include <arm_acle.h>