[review] Minor fix to gdb.prompt documentation

Message ID gerrit.1574291371000.I4153928c0d88001244ad410f3943c952a6ebfeb1@gnutoolchain-gerrit.osci.io
State New
Headers show
Series
  • [review] Minor fix to gdb.prompt documentation
Related show

Commit Message

Simon Marchi (Code Review) Nov. 20, 2019, 11:09 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................

Minor fix to gdb.prompt documentation

I noticed that an example in the gdb.prompt documentation used the
wrong kind of quotes -- because it is code, it should use a plain
ASCII quotation mark.  I also slightly shortened the sample text here,
so it would more clearly fit on a single line.

gdb/doc/ChangeLog
2019-11-20  Tom Tromey  <tom@tromey.com>

	* python.texi (gdb.prompt): Use correct quotes in example.
	Shorten sample text.

Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
---
M gdb/doc/ChangeLog
M gdb/doc/python.texi
2 files changed, 7 insertions(+), 3 deletions(-)




-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange

Comments

Tom Tromey Dec. 4, 2019, 10:23 p.m. | #1
>>>>> "Tom" == Tom Tromey (Code Review) <gerrit@gnutoolchain-gerrit.osci.io> writes:


Tom> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
Tom> ......................................................................

Tom> Minor fix to gdb.prompt documentation

...

Tom> gdb/doc/ChangeLog
Tom> 2019-11-20  Tom Tromey  <tom@tromey.com>

Tom> 	* python.texi (gdb.prompt): Use correct quotes in example.
Tom> 	Shorten sample text.


Ping.

Tom
Simon Marchi (Code Review) Dec. 6, 2019, 6:54 p.m. | #2
Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................


Patch Set 1: Code-Review+2


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 18:54:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Simon Marchi (Code Review) Dec. 6, 2019, 6:54 p.m. | #3
Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................


Patch Set 1:

(I think this can go in as obvious.)


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 18:54:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Patch

diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 2571839..c7eb50c 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-11-20  Tom Tromey  <tom@tromey.com>
+
+	* python.texi (gdb.prompt): Use correct quotes in example.
+	Shorten sample text.
+
 2019-11-14  Tom de Vries  <tdevries@suse.de>
 
 	* gdb.texinfo: Fix typos.
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index ed73bbf..f807fb2 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -5937,13 +5937,12 @@ 
 For example:
 
 @smallexample
-substitute_prompt (``frame: \f,
-                   print arguments: \p@{print frame-arguments@}'')
+substitute_prompt ("frame: \f, args: \p@{print frame-arguments@}")
 @end smallexample
 
 @exdent will return the string:
 
 @smallexample
-"frame: main, print arguments: scalars"
+"frame: main, args: scalars"
 @end smallexample
 @end table