[review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp

Message ID gerrit.1573572186000.Ie760a2856cae3be0eeed5496765a5f1cd102d6b7@gnutoolchain-gerrit.osci.io
State New
Headers show
Series
  • [review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
Related show

Commit Message

Pedro Alves (Code Review) Nov. 12, 2019, 3:23 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/618
......................................................................

gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp

Simplify the expected test outputs.  This is a minor cleanup; no
functional change is intended.

gdb/testsuite/ChangeLog:
2019-11-12  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

	* gdb.cp/rvalue-ref-overload.exp: Minor cleanup.

Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
---
M gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
1 file changed, 5 insertions(+), 9 deletions(-)




-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
Gerrit-Change-Number: 618
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-MessageType: newchange

Comments

Pedro Alves (Code Review) Dec. 5, 2019, 8:14 p.m. | #1
Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/618
......................................................................


Patch Set 1: Code-Review+2

Thank you.  This is ok.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
Gerrit-Change-Number: 618
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 05 Dec 2019 20:14:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Patch

diff --git a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
index 693c7ca..e92e901 100644
--- a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
+++ b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
@@ -53,20 +53,16 @@ 
 	{ method public "int overloadConst(const foo &&);" }
     }
 
-gdb_test "print foo_rr_instance1.overload1arg(arg)" \
-    "\\$\[0-9\]+ = 1" \
-    "print call overloaded func foo & arg"
+gdb_test "print foo_rr_instance1.overload1arg(arg)" "1"
 
-gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" \
-    "\\$\[0-9\]+ = 2" \
-    "print call overloaded func foo && arg"
+gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" "2"
 
 gdb_test "print foo_rr_instance1.overloadConst(arg)" "3"
 
 # Test lvalue vs rvalue function overloads
-gdb_test "print f (i)" "= 1" "lvalue reference overload"
+gdb_test "print f (i)" "1" "lvalue reference overload"
 
-gdb_test "print f (ci)" "= 2" "lvalue reference to const overload"
+gdb_test "print f (ci)" "2" "lvalue reference to const overload"
 
 setup_kfail "c++/15372" "*-*-*"
-gdb_test "print f (3)" "= 3" "rvalue reference overload"
+gdb_test "print f (3)" "3" "rvalue reference overload"