[pushed] gdb: Convert frame_show_address to return a bool

Message ID 20191110210206.EE74D20AF6@gnutoolchain-gerrit.osci.io
State Superseded
Headers show
Series
  • [pushed] gdb: Convert frame_show_address to return a bool
Related show

Commit Message

Sourceware to Gerrit sync (Code Review) Nov. 10, 2019, 9:02 p.m.
The original change was created by Andrew Burgess.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541
......................................................................

gdb: Convert frame_show_address to return a bool

Just a clean up, should be no user visible changes after this commit.

gdb/ChangeLog:

	* stack.c (frame_show_address): Convert return type to bool.
	* stack.h (frame_show_address): Likewise, and update header
	comment.

Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f
---
M gdb/ChangeLog
M gdb/stack.c
M gdb/stack.h
3 files changed, 10 insertions(+), 4 deletions(-)




-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f
Gerrit-Change-Number: 541
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: newpatchset

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b9d5f21..158af82 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@ 
 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 
+	* stack.c (frame_show_address): Convert return type to bool.
+	* stack.h (frame_show_address): Likewise, and update header
+	comment.
+
+2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
+
 	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 	* unittests/vec-utils-selftests.c: New file.
 	* gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
diff --git a/gdb/stack.c b/gdb/stack.c
index fa057db..5af00c7 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -252,7 +252,7 @@ 
 
 /* See stack.h.  */
 
-int
+bool
 frame_show_address (struct frame_info *frame,
 		    struct symtab_and_line sal)
 {
@@ -267,7 +267,7 @@ 
 	gdb_assert (inline_skipped_frames (inferior_thread ()) > 0);
       else
 	gdb_assert (get_frame_type (get_next_frame (frame)) == INLINE_FRAME);
-      return 0;
+      return false;
     }
 
   return get_frame_pc (frame) != sal.pc;
diff --git a/gdb/stack.h b/gdb/stack.h
index dda4fc9..28d2273 100644
--- a/gdb/stack.h
+++ b/gdb/stack.h
@@ -49,10 +49,10 @@ 
 
 void get_user_print_what_frame_info (gdb::optional<enum print_what> *what);
 
-/* Return 1 if we should display the address in addition to the location,
+/* Return true if we should display the address in addition to the location,
    because we are in the middle of a statement.  */
 
-int frame_show_address (struct frame_info *frame, struct symtab_and_line sal);
+bool frame_show_address (struct frame_info *frame, struct symtab_and_line sal);
 
 /* Get or set the last displayed symtab and line, which is, e.g. where we set a
  * breakpoint when `break' is supplied with no arguments.  */