[review] Move can_box to tui_gen_win_info

Message ID gerrit.1573050458000.Idfa58af41341607932d3c39415f6a35ee9b5d3dc@gnutoolchain-gerrit.osci.io
State Superseded
Headers show
Series
  • [review] Move can_box to tui_gen_win_info
Related show

Commit Message

Sourceware to Gerrit sync (Code Review) Nov. 6, 2019, 2:27 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/512
......................................................................

Move can_box to tui_gen_win_info

This moves the can_box method to tui_gen_win_info, so that it will be
available for the locator.  This will be used in a subsequent patch.

gdb/ChangeLog
2019-11-06  Tom Tromey  <tom@tromey.com>

	* tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
	(struct tui_win_info) <can_box>: Update.

Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc
---
M gdb/ChangeLog
M gdb/tui/tui-data.h
2 files changed, 12 insertions(+), 1 deletion(-)




-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc
Gerrit-Change-Number: 512
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange

Comments

Sourceware to Gerrit sync (Code Review) Nov. 13, 2019, 10:18 a.m. | #1
Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/512
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Really, really minor nit with the commit message, but otherwise LGTM.  Thanks.

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,18 @@ 
| +Parent:     d8f6abf8 (Move max_height method to tui_gen_win_info)
| +Author:     Tom Tromey <tom@tromey.com>
| +AuthorDate: 2019-11-05 17:12:04 -0700
| +Commit:     Tom Tromey <tom@tromey.com>
| +CommitDate: 2019-11-06 06:23:33 -0700
| +
| +Move can_box to tui_gen_win_info
| +
| +This moves the can_box method to tui_gen_win_info, so that it will be
| +available for the locator.  This will be used in a subsequent patch.

PS1, Line 10:

It's really minor, but saying "locator" here meant I had to go and dig
through the code to figure out / confirm that this was a reference to
a class.  Could you say "...available in the tui_locator_window
class." or similar.

| +
| +gdb/ChangeLog
| +2019-11-06  Tom Tromey  <tom@tromey.com>
| +
| +	* tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
| +	(struct tui_win_info) <can_box>: Update.
| +
| +Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc
Gerrit-Change-Number: 512
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 10:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Sourceware to Gerrit sync (Code Review) Nov. 22, 2019, 11:50 p.m. | #2
Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/512
......................................................................


Patch Set 3: Code-Review+2

Still LGTM :)


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc
Gerrit-Change-Number: 512
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 23:50:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1daaf14..02d6364 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@ 
 2019-11-06  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
+	(struct tui_win_info) <can_box>: Update.
+
+2019-11-06  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 	method.
 	* tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 0131aa4..b0183a3 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -85,6 +85,12 @@ 
   /* Compute the maximum height of this window.  */
   virtual int max_height () const = 0;
 
+  /* Return true if this window can be boxed.  */
+  virtual bool can_box () const
+  {
+    return false;
+  }
+
   /* Resize this window.  The parameters are used to set the window's
      size and position.  */
   virtual void resize (int height, int width,
@@ -203,7 +209,7 @@ 
     return true;
   }
 
-  virtual bool can_box () const
+  bool can_box () const override
   {
     return true;
   }