Reduce inline-heuristics-hint-percent (to fix exchange2 regression)

Message ID 20191023150738.nhdvre7exyxwfusk@kam.mff.cuni.cz
State New
Headers show
Series
  • Reduce inline-heuristics-hint-percent (to fix exchange2 regression)
Related show

Commit Message

Jan Hubicka Oct. 23, 2019, 3:07 p.m.
Hi,
this patch reduces inline-heuristics-hint-percent so inliner behaves
more similarly to what it did before I introduced this param.

Bootstrapped/regtested x86_64-linux, comitted.
I plan to do more tuning on this parameter, but the value of 1600 was
actually a typo.

Comments

Jeff Law Oct. 23, 2019, 3:11 p.m. | #1
On 10/23/19 9:07 AM, Jan Hubicka wrote:
> Hi,

> this patch reduces inline-heuristics-hint-percent so inliner behaves

> more similarly to what it did before I introduced this param.

> 

> Bootstrapped/regtested x86_64-linux, comitted.

> I plan to do more tuning on this parameter, but the value of 1600 was

> actually a typo.

> 

> Index: ChangeLog

> ===================================================================

> --- ChangeLog	(revision 277332)

> +++ ChangeLog	(working copy)

> @@ -1,3 +1,8 @@

> +2019-10-23  Jan Hubicka  <hubicka@ucw.cz>

> +

> +	PR ipa/92074

> +	* params.def (inline-heuristics-hint-percent): Set to 600.

Funny, I just contacted all the package owners that were failing because
of the inliner heuristic changes.  Given they were using the old
semantics, it's still good to encourage them to fix their code :-)


Jeff
Jan Hubicka Oct. 23, 2019, 4:20 p.m. | #2
> On 10/23/19 9:07 AM, Jan Hubicka wrote:

> > Hi,

> > this patch reduces inline-heuristics-hint-percent so inliner behaves

> > more similarly to what it did before I introduced this param.

> > 

> > Bootstrapped/regtested x86_64-linux, comitted.

> > I plan to do more tuning on this parameter, but the value of 1600 was

> > actually a typo.

> > 

> > Index: ChangeLog

> > ===================================================================

> > --- ChangeLog	(revision 277332)

> > +++ ChangeLog	(working copy)

> > @@ -1,3 +1,8 @@

> > +2019-10-23  Jan Hubicka  <hubicka@ucw.cz>

> > +

> > +	PR ipa/92074

> > +	* params.def (inline-heuristics-hint-percent): Set to 600.

> Funny, I just contacted all the package owners that were failing because

> of the inliner heuristic changes.  Given they were using the old

> semantics, it's still good to encourage them to fix their code :-)


I think most of changes in warnings you see is due to enabling
-finline-functions at -O2.  This change affects -O3/-Ofast only and not
by that much. :)

Honza
> 

> 

> Jeff

>

Patch

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 277332)
+++ ChangeLog	(working copy)
@@ -1,3 +1,8 @@ 
+2019-10-23  Jan Hubicka  <hubicka@ucw.cz>
+
+	PR ipa/92074
+	* params.def (inline-heuristics-hint-percent): Set to 600.
+
 2019-10-23  Richard Biener  <rguenther@suse.de>
 
 	PR tree-optimization/65930
Index: params.def
===================================================================
--- params.def	(revision 277330)
+++ params.def	(working copy)
@@ -105,7 +105,7 @@  DEFPARAM (PARAM_MAX_INLINE_INSNS_SMALL,
 DEFPARAM (PARAM_INLINE_HEURISTICS_HINT_PERCENT,
 	  "inline-heuristics-hint-percent",
 	  "The scale (in percents) applied to inline-insns-single and auto limits when heuristics hints that inlining is very profitable with -O3 and -Ofast.",
-	  1600, 100, 1000000)
+	  600, 100, 1000000)
 
 DEFPARAM (PARAM_INLINE_HEURISTICS_HINT_PERCENT_O2,
 	  "inline-heuristics-hint-percent-O2",