PR25100, Compile fails in elf64-ppc.c because of single equal sign instead of double equal for comparison

Message ID 20191015061502.GP10114@bubble.grove.modra.org
State New
Headers show
Series
  • PR25100, Compile fails in elf64-ppc.c because of single equal sign instead of double equal for comparison
Related show

Commit Message

Alan Modra Oct. 15, 2019, 6:15 a.m.
PR 25100
	* elf64-ppc.c (sfpr_define): Delete dead code that triggered a warning.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 2731e78618..4ece6fbde0 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -5837,9 +5837,7 @@  sfpr_define (struct bfd_link_info *info,
 	      s = elf_link_hash_lookup (&htab->elf, buf, TRUE, TRUE, FALSE);
 	      if (s == NULL)
 		return FALSE;
-	      if (s->root.type == bfd_link_hash_new
-		  || (s->root.type = bfd_link_hash_defined
-		      && s->root.u.def.section == stub_sec))
+	      if (s->root.type == bfd_link_hash_new)
 		{
 		  s->root.type = bfd_link_hash_defined;
 		  s->root.u.def.section = stub_sec;