PR25081, Discrepancy between VMA and LMA after ALIGN

Message ID 20191009112948.GR7064@bubble.grove.modra.org
State New
Headers show
Series
  • PR25081, Discrepancy between VMA and LMA after ALIGN
Related show

Commit Message

Alan Modra Oct. 9, 2019, 11:29 a.m.
The testcase in the PR has two empty output sections, .sec1 with an
ALIGN and symbol assignment, and .sec2 just with an empty input
section.  The symbol assignment results in .sec1 being kept, but
because it is empty this section doesn't take space from the memory
region as you might expect from the ALIGN.  Instead the next section
.sec2, has vma/lma as if .sec1 wasn't present.  However, .sec2 is
discarded and os->ignored set, which unfortunately meant that dot
wasn't set from .sec2 vma.  That in turn results in .sec2 lma being
set incorrectly.  That vma/lma difference is then propagated to
.sec3 where it is seen as an overlap.

	PR 25081
	* ldlang.c (lang_size_sections_1): Set lma from section vma
	rather than dot.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/ld/ldlang.c b/ld/ldlang.c
index 2f72a7cdfd..df7f659486 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -5691,7 +5691,7 @@  lang_size_sections_1
 		    /* Otherwise, keep the same lma to vma relationship
 		       as the previous section.  */
 		    else
-		      lma = dot + last->lma - last->vma;
+		      lma = os->bfd_section->vma + last->lma - last->vma;
 
 		    if (section_alignment > 0)
 		      lma = align_power (lma, section_alignment);