[committed,gdb/testsuite] Make pass message unique in gdb-index.exp for cc-with-dwz-m

Message ID 20190929215246.GA23098@delia
State New
Headers show
Series
  • [committed,gdb/testsuite] Make pass message unique in gdb-index.exp for cc-with-dwz-m
Related show

Commit Message

Tom de Vries Sept. 29, 2019, 9:52 p.m.
Hi,

With cc-with-dwz-m, we get:
...
PASS: gdb.dwarf2/gdb-index.exp: objcopy
PASS: gdb.dwarf2/gdb-index.exp: objcopy
...

Make the pass message unique by using with_test_prefix:
...
PASS: gdb.dwarf2/gdb-index.exp: objcopy
PASS: gdb.dwarf2/gdb-index.exp: modify dwz file: objcopy
...

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Make pass message unique in gdb-index.exp for cc-with-dwz-m

gdb/testsuite/ChangeLog:

2019-09-29  Tom de Vries  <tdevries@suse.de>

	* gdb.dwarf2/gdb-index.exp: Use with_test_prefix for second objcopy.

---
 gdb/testsuite/gdb.dwarf2/gdb-index.exp | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

Patch

diff --git a/gdb/testsuite/gdb.dwarf2/gdb-index.exp b/gdb/testsuite/gdb.dwarf2/gdb-index.exp
index 6fca3c61299..b14e07fa55d 100644
--- a/gdb/testsuite/gdb.dwarf2/gdb-index.exp
+++ b/gdb/testsuite/gdb.dwarf2/gdb-index.exp
@@ -59,14 +59,16 @@  proc add_gdb_index { program } {
 	return ""
     }
 
-    if { [remote_file host exists ${dwz_index_file}] } {
-	# We're modifying $dwz in place, otherwise we'd have to update
-	# .gnu_debugaltlink in $program.
-	set args [join [list "--remove-section .gdb_index" \
-			    " --add-section .gdb_index=$dwz_index_file" \
-			    " --set-section-flags .gdb_index=readonly $dwz"]]
-	if {[run_on_host "objcopy" [gdb_find_objcopy] "$args"]} {
-	    return ""
+    with_test_prefix "modify dwz file" {
+	if { [remote_file host exists ${dwz_index_file}] } {
+	    # We're modifying $dwz in place, otherwise we'd have to update
+	    # .gnu_debugaltlink in $program.
+	    set args [join [list "--remove-section .gdb_index" \
+				" --add-section .gdb_index=$dwz_index_file" \
+				" --set-section-flags .gdb_index=readonly $dwz"]]
+	    if {[run_on_host "objcopy" [gdb_find_objcopy] "$args"]} {
+		return ""
+	    }
 	}
     }