[committed,gdb/testsuite] Fix incomplete regexps in step-precsave.exp

Message ID b50b18ce-2ab9-e1b9-39f8-a185ea036545@suse.de
State New
Headers show
Series
  • [committed,gdb/testsuite] Fix incomplete regexps in step-precsave.exp
Related show

Commit Message

Tom de Vries Sept. 27, 2019, 3:07 p.m.
[ was: Re: [committed][gdb/testsuite] Add KFAIL for missing support of
reverse-debugging of vmovd ]

On 27-09-19 10:37, Tom de Vries wrote:
> Hi,

> 

> On my openSUSE Leap 15.1 system I run into:

> ...

> (gdb) PASS: gdb.reverse/step-precsave.exp: turn on process record

> break 76^M

> Breakpoint 2 at 0x400654: file step-reverse.c, line 76.^M

> (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main

> continue^M

> Continuing.^M

> Process record does not support instruction 0xc5 at address 0x7ffff783fc70.^M

> Process record: failed to record execution log.^M

> ^M

> Program stopped.^M

> 0x00007ffff783fc70 in __memset_avx2_unaligned_erms () from /lib64/libc.so.6^M

> (gdb) FAIL: gdb.reverse/step-precsave.exp: run to end of main

> ...

> 

> The problem is that the vmovd instruction is not supported in

> reverse-debugging (PR record/23188).

> 

> Add a KFAIL for this PR.

> 


This fixes an oversight in the previous patch.

Thanks,
- Tom

Patch

[gdb/testsuite] Fix incomplete regexps in step-precsave.exp

The commit 68f7d34dd50 "[gdb/testsuite] Add KFAIL for missing support of
reverse-debugging of vmovd" rewrites a gdb_test into a gdb_test_multiple but
forgets to add the $gdb_prompt part in the regexp.

Add the missing parts of the regexps.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2019-09-27  Tom de Vries  <tdevries@suse.de>

	* gdb.reverse/step-precsave.exp: Add missing $gdb_prompt in regexps.

---
 gdb/testsuite/gdb.reverse/step-precsave.exp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.reverse/step-precsave.exp b/gdb/testsuite/gdb.reverse/step-precsave.exp
index f5e15510e1f..2073b8a1542 100644
--- a/gdb/testsuite/gdb.reverse/step-precsave.exp
+++ b/gdb/testsuite/gdb.reverse/step-precsave.exp
@@ -47,11 +47,13 @@  gdb_test "break $end_of_main" \
 # This can take awhile.
 with_timeout_factor 20 {
     set test "run to end of main"
+    set pass_pattern "Breakpoint .* end of main .*"
+    set kfail_pattern "Process record does not support instruction 0xc5 at.*"
     gdb_test_multiple "continue" $test {
-	-re "Breakpoint .* end of main .*" {
+	-re "\[\r\n\]*(?:$pass_pattern)\[\r\n\]+$gdb_prompt $" {
 	    pass $test
 	}
-	-re "Process record does not support instruction 0xc5 at.*$gdb_prompt $" {
+	-re "\[\r\n\]*(?:$kfail_pattern)\[\r\n\]+$gdb_prompt $" {
 	    kfail "record/23188" $test
 	}
     }