x86: Uppercase suffix_always in the comments

Message ID 20190709150047.GA1930@nazgul.tnic
State New
Headers show
Series
  • x86: Uppercase suffix_always in the comments
Related show

Commit Message

Borislav Petkov July 9, 2019, 3 p.m.
... to clarify which bit flag the uppercase macros explanation refers
to. Also, it is a bit flag now so adjust the text to better reflect
that.

No functionality change.
---
 opcodes/ChangeLog  |  4 ++++
 opcodes/i386-dis.c | 24 ++++++++++++------------
 2 files changed, 16 insertions(+), 12 deletions(-)

-- 
2.18.0.321.gffc6fa0e3962

SUSE Linux GmbH, GF: Felix Imend├Ârffer, Mary Higgins, Sri Rasiah, HRB 21284 (AG N├╝rnberg)
--

Comments

H.J. Lu July 9, 2019, 3:18 p.m. | #1
On Tue, Jul 9, 2019 at 8:01 AM Borislav Petkov <bp@suse.de> wrote:
>

> ... to clarify which bit flag the uppercase macros explanation refers

> to. Also, it is a bit flag now so adjust the text to better reflect

> that.

>

> No functionality change.

> ---

>  opcodes/ChangeLog  |  4 ++++

>  opcodes/i386-dis.c | 24 ++++++++++++------------

>  2 files changed, 16 insertions(+), 12 deletions(-)

>

> diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog

> index 85a2842e30b9..5f9d56afa7cf 100644

> --- a/opcodes/ChangeLog

> +++ b/opcodes/ChangeLog

> @@ -1,3 +1,7 @@

> +2019-07-09  Borislav Petkov <bp@suse.de>

> +

> +       * i386-dis.c (dis386): Uppercase SUFFIX_ALWAYS to clarify comments.

> +

>  2019-07-05  Kito Cheng <kito.cheng@sifive.com>

>

>         * riscv-opc.c (riscv_insn_types): Add r4 type.


OK.

Thanks.


-- 
H.J.

Patch

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 85a2842e30b9..5f9d56afa7cf 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,7 @@ 
+2019-07-09  Borislav Petkov <bp@suse.de>
+
+	* i386-dis.c (dis386): Uppercase SUFFIX_ALWAYS to clarify comments.
+
 2019-07-05  Kito Cheng <kito.cheng@sifive.com>
 
 	* riscv-opc.c (riscv_insn_types): Add r4 type.
diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index dc814209256a..2508591bc218 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -2293,12 +2293,12 @@  struct dis386 {
 };
 
 /* Upper case letters in the instruction names here are macros.
-   'A' => print 'b' if no register operands or suffix_always is true
-   'B' => print 'b' if suffix_always is true
+   'A' => print 'b' if no register operands or SUFFIX_ALWAYS is set
+   'B' => print 'b' if SUFFIX_ALWAYS is set
    'C' => print 's' or 'l' ('w' or 'd' in Intel mode) depending on operand
 	  size prefix
    'D' => print 'w' if no register operands or 'w', 'l' or 'q', if
-	  suffix_always is true
+	  SUFFIX_ALWAYS is set
    'E' => print 'e' if 32-bit form of jcxz
    'F' => print 'w' or 'l' depending on address size prefix (loop insns)
    'G' => print 'w' or 'l' depending on operand size prefix (i/o insns)
@@ -2307,16 +2307,16 @@  struct dis386 {
 	  for some of the macro letters)
    'J' => print 'l'
    'K' => print 'd' or 'q' if rex prefix is present.
-   'L' => print 'l' if suffix_always is true
+   'L' => print 'l' if SUFFIX_ALWAYS is set
    'M' => print 'r' if intel_mnemonic is false.
    'N' => print 'n' if instruction has no wait "prefix"
    'O' => print 'd' or 'o' (or 'q' in Intel mode)
    'P' => print 'w', 'l' or 'q' if instruction has an operand size prefix,
-	  or suffix_always is true.  print 'q' if rex prefix is present.
-   'Q' => print 'w', 'l' or 'q' for memory operand or suffix_always
+	  or SUFFIX_ALWAYS is set.  print 'q' if rex prefix is present.
+   'Q' => print 'w', 'l' or 'q' for memory operand or SUFFIX_ALWAYS
 	  is true
    'R' => print 'w', 'l' or 'q' ('d' for 'l' and 'e' in Intel mode)
-   'S' => print 'w', 'l' or 'q' if suffix_always is true
+   'S' => print 'w', 'l' or 'q' if SUFFIX_ALWAYS is set
    'T' => print 'q' in 64bit mode if instruction has no operand size
 	  prefix and behave as 'P' otherwise
    'U' => print 'q' in 64bit mode if instruction has no operand size
@@ -2330,7 +2330,7 @@  struct dis386 {
    '!' => change condition from true to false or from false to true.
    '%' => add 1 upper case letter to the macro.
    '^' => print 'w' or 'l' depending on operand size prefix or
-	  suffix_always is true (lcall/ljmp).
+	  SUFFIX_ALWAYS is set (lcall/ljmp).
    '@' => print 'q' for Intel64 ISA, 'w' or 'q' for AMD64 ISA depending
 	  on operand size prefix.
    '&' => print 'q' in 64bit mode for Intel64 ISA or if instruction
@@ -2338,19 +2338,19 @@  struct dis386 {
 	  otherwise
 
    2 upper case letter macros:
-   "XY" => print 'x' or 'y' if suffix_always is true or no register
+   "XY" => print 'x' or 'y' if SUFFIX_ALWAYS is set or no register
 	   operands and no broadcast.
-   "XZ" => print 'x', 'y', or 'z' if suffix_always is true or no
+   "XZ" => print 'x', 'y', or 'z' if SUFFIX_ALWAYS is set or no
 	   register operands and no broadcast.
    "XW" => print 's', 'd' depending on the VEX.W bit (for FMA)
    "LQ" => print 'l' ('d' in Intel mode) or 'q' for memory operand
-	   or suffix_always is true
+	   or SUFFIX_ALWAYS is set
    "LB" => print "abs" in 64bit mode and behave as 'B' otherwise
    "LS" => print "abs" in 64bit mode and behave as 'S' otherwise
    "LV" => print "abs" for 64bit operand and behave as 'S' otherwise
    "LW" => print 'd', 'q' depending on the VEX.W bit
    "LP" => print 'w' or 'l' ('d' in Intel mode) if instruction has
-	   an operand size prefix, or suffix_always is true.  print
+	   an operand size prefix, or SUFFIX_ALWAYS is set.  print
 	   'q' if rex prefix is present.
 
    Many of the above letters print nothing in Intel mode.  See "putop"