[06/11,mips] Fix ambiguous .md attribute uses

Message ID mpt1rz4y0hs.fsf@arm.com
State New
Headers show
Series
  • Diagnose ambiguous .md attribute uses
Related show

Commit Message

Richard Sandiford July 5, 2019, 3:17 p.m.
This patch is part of a series that fixes ambiguous attribute
uses in .md files, i.e. cases in which attributes didn't use
<ITER:ATTR> to specify an iterator, and in which <ATTR> could
have different values depending on the iterator chosen.

No behavioural change -- produces the same code as before.


2019-07-05  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
	* config/mips/micromips.md (*movep<MOVEP1:mode><MOVEP2:mode>):
	Explicitly use <MOVEP1:MODE> for the mode attribute.

Comments

Richard Sandiford July 12, 2019, 8:16 a.m. | #1
Ping.  I think this is the only one of the series left.

(I should probably have treated the patch as obvious, but it always
seems wrong to do that retrospectively.)

Thanks,
Richard

Richard Sandiford <richard.sandiford@arm.com> writes:
> This patch is part of a series that fixes ambiguous attribute

> uses in .md files, i.e. cases in which attributes didn't use

> <ITER:ATTR> to specify an iterator, and in which <ATTR> could

> have different values depending on the iterator chosen.

>

> No behavioural change -- produces the same code as before.

>

>

> 2019-07-05  Richard Sandiford  <richard.sandiford@arm.com>

>

> gcc/

> 	* config/mips/micromips.md (*movep<MOVEP1:mode><MOVEP2:mode>):

> 	Explicitly use <MOVEP1:MODE> for the mode attribute.

>

> Index: gcc/config/mips/micromips.md

> ===================================================================

> --- gcc/config/mips/micromips.md	2019-03-08 18:15:39.000731609 +0000

> +++ gcc/config/mips/micromips.md	2019-07-05 15:07:29.083455268 +0100

> @@ -133,5 +133,5 @@ (define_insn "*movep<MOVEP1:mode><MOVEP2

>      return "movep\t%2,%0,%z3,%z1";

>  }

>    [(set_attr "type" "move")

> -   (set_attr "mode" "<MODE>")

> +   (set_attr "mode" "<MOVEP1:MODE>")

>     (set_attr "can_delay" "no")])
Jim Wilson July 15, 2019, 6:16 p.m. | #2
On 7/12/19 1:16 AM, Richard Sandiford wrote:
> Ping.  I think this is the only one of the series left.

> 

>> 2019-07-05  Richard Sandiford  <richard.sandiford@arm.com>

>> gcc/

>> 	* config/mips/micromips.md (*movep<MOVEP1:mode><MOVEP2:mode>):

>> 	Explicitly use <MOVEP1:MODE> for the mode attribute.


OK.

Jim

Patch

Index: gcc/config/mips/micromips.md
===================================================================
--- gcc/config/mips/micromips.md	2019-03-08 18:15:39.000731609 +0000
+++ gcc/config/mips/micromips.md	2019-07-05 15:07:29.083455268 +0100
@@ -133,5 +133,5 @@  (define_insn "*movep<MOVEP1:mode><MOVEP2
     return "movep\t%2,%0,%z3,%z1";
 }
   [(set_attr "type" "move")
-   (set_attr "mode" "<MODE>")
+   (set_attr "mode" "<MOVEP1:MODE>")
    (set_attr "can_delay" "no")])