[04/11,h8300] Fix ambiguous .md attribute uses

Message ID mptbly8y0ni.fsf@arm.com
State New
Headers show
Series
  • Diagnose ambiguous .md attribute uses
Related show

Commit Message

Richard Sandiford July 5, 2019, 3:13 p.m.
This patch is part of a series that fixes ambiguous attribute
uses in .md files, i.e. cases in which attributes didn't use
<ITER:ATTR> to specify an iterator, and in which <ATTR> could
have different values depending on the iterator chosen.

No behavioural change -- produces the same code as before.


2019-07-05  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
	* config/h8300/h8300.md (*push1_h8300hs_<mode>): Explicitly
	specify the mode iterator referenced by <mode>, giving...
	(*push1_h8300hs_<QHI:mode>): ...this.

Comments

Jeff Law July 5, 2019, 4:38 p.m. | #1
On 7/5/19 9:13 AM, Richard Sandiford wrote:
> This patch is part of a series that fixes ambiguous attribute

> uses in .md files, i.e. cases in which attributes didn't use

> <ITER:ATTR> to specify an iterator, and in which <ATTR> could

> have different values depending on the iterator chosen.

> 

> No behavioural change -- produces the same code as before.

> 

> 

> 2019-07-05  Richard Sandiford  <richard.sandiford@arm.com>

> 

> gcc/

> 	* config/h8300/h8300.md (*push1_h8300hs_<mode>): Explicitly

> 	specify the mode iterator referenced by <mode>, giving...

> 	(*push1_h8300hs_<QHI:mode>): ...this.

OK
jeff

Patch

Index: gcc/config/h8300/h8300.md
===================================================================
--- gcc/config/h8300/h8300.md	2019-07-01 09:37:07.328523581 +0100
+++ gcc/config/h8300/h8300.md	2019-07-05 15:06:32.491921996 +0100
@@ -728,7 +728,7 @@  (define_insn "*pushqi1_h8300"
   "mov.w\\t%T0,@-r7"
   [(set_attr "length" "2")])
 
-(define_insn "*push1_h8300hs_<mode>"
+(define_insn "*push1_h8300hs_<QHI:mode>"
   [(set (mem:QHI
 	(pre_modify:P
 	  (reg:P SP_REG)