[v2,1/5] RISC-V: Fix doc for .insn

Message ID 20190702095801.32062-1-kito.cheng@sifive.com
State New
Headers show
Series
  • [v2,1/5] RISC-V: Fix doc for .insn
Related show

Commit Message

Kito Cheng July 2, 2019, 9:57 a.m.
gas/ChangeLog:

	* doc/c-riscv.texi (Instruction Formats): Fix encoding table for SB
	type and fix typo.
---
 gas/doc/c-riscv.texi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.17.1

Comments

Jim Wilson July 5, 2019, 4:29 a.m. | #1
On Tue, Jul 2, 2019 at 5:58 PM Kito Cheng <kito.cheng@sifive.com> wrote:
> gas/ChangeLog:

>         * doc/c-riscv.texi (Instruction Formats): Fix encoding table for SB

>         type and fix typo.


This is OK.  I believe you have commit access to binutils.  You want
to check this in?

Jim
Kito Cheng July 5, 2019, 5:46 a.m. | #2
Hi Jim:

No, I didn't have commit access yet, could you help me to check in
those 5 patches, thanks :)


On Fri, Jul 5, 2019 at 12:29 PM Jim Wilson <jimw@sifive.com> wrote:
>

> On Tue, Jul 2, 2019 at 5:58 PM Kito Cheng <kito.cheng@sifive.com> wrote:

> > gas/ChangeLog:

> >         * doc/c-riscv.texi (Instruction Formats): Fix encoding table for SB

> >         type and fix typo.

>

> This is OK.  I believe you have commit access to binutils.  You want

> to check this in?

>

> Jim
Jim Wilson July 5, 2019, 7:23 a.m. | #3
On Fri, Jul 5, 2019 at 1:46 PM Kito Cheng <kito.cheng@sifive.com> wrote:
> No, I didn't have commit access yet, could you help me to check in

> those 5 patches, thanks :)


OK.  Committed and pushed.

Jim

Patch

diff --git a/gas/doc/c-riscv.texi b/gas/doc/c-riscv.texi
index 42d1ce3e5f..5c30db1b83 100644
--- a/gas/doc/c-riscv.texi
+++ b/gas/doc/c-riscv.texi
@@ -286,7 +286,7 @@  Opcode space for msub instruction.
 @item AMO
 Opcode space for atomic memory operation instructions.
 
-@item MISC_IMM
+@item MISC_MEM
 Opcode space for misc instructions.
 
 @item SYSTEM
@@ -344,10 +344,10 @@  with the @samp{.insn} pseudo directive:
 @item SB type: .insn sb opcode, func3, rd, rs1, symbol
 @itemx SB type: .insn sb opcode, func3, rd, simm12(rs1)
 @verbatim
-+--------------+-----+-----+-------+-------------+-------------+
-| simm21[11:5] | rs2 | rs1 | func3 | simm12[4:0] |      opcode |
-+--------------+-----+-----+-------+-------------+-------------+
-31             25    20    15      12            7             0
++------------+--------------+-----+-----+-------+-------------+-------------+--------+
+| simm12[12] | simm12[10:5] | rs2 | rs1 | func3 | simm12[4:1] | simm12[11]] | opcode |
++------------+--------------+-----+-----+-------+-------------+-------------+--------+
+31          30            25    20    15      12           7            0
 @end verbatim
 
 @item U type: .insn u opcode, rd, simm20