[doc] extend.texi -- clarify no_sanitize

Message ID alpine.LSU.2.21.1906091731180.3441@anthias.pfeifer.com
State New
Headers show
Series
  • [doc] extend.texi -- clarify no_sanitize
Related show

Commit Message

Gerald Pfeifer June 9, 2019, 3:42 p.m.
In some interpretations "not...of all" may not be seen as 
100% clear, so I propose to use "not...of any".

On the way fix the grammar in the next sentence.

Sandra, and Martin as the original author, does this makes 
sense for you?

Gerald


2019-06-09  Gerald Pfeifer  <gerald@pfeifer.com>

	* doc/extend.texi (Common Function Attributes): Clarify
	no_sanitize.  Fix grammar.

Comments

Martin Liška June 10, 2019, 7:09 a.m. | #1
On 6/9/19 5:42 PM, Gerald Pfeifer wrote:
> In some interpretations "not...of all" may not be seen as 

> 100% clear, so I propose to use "not...of any".

> 

> On the way fix the grammar in the next sentence.

> 

> Sandra, and Martin as the original author, does this makes 

> sense for you?


I'm fine with the Gerald. Thank you for it.

Martin

> 

> Gerald

> 

> 

> 2019-06-09  Gerald Pfeifer  <gerald@pfeifer.com>

> 

> 	* doc/extend.texi (Common Function Attributes): Clarify

> 	no_sanitize.  Fix grammar.

> 

> Index: doc/extend.texi

> ===================================================================

> --- doc/extend.texi	(revision 272089)

> +++ doc/extend.texi	(working copy)

> @@ -3215,9 +3215,9 @@ marked symbols.

>  @item no_sanitize ("@var{sanitize_option}")

>  @cindex @code{no_sanitize} function attribute

>  The @code{no_sanitize} attribute on functions is used

> -to inform the compiler that it should not do sanitization of all options

> +to inform the compiler that it should not do sanitization of any option

>  mentioned in @var{sanitize_option}.  A list of values acceptable by

> -@option{-fsanitize} option can be provided.

> +the @option{-fsanitize} option can be provided.

>  

>  @smallexample

>  void __attribute__ ((no_sanitize ("alignment", "object-size")))

>
Gerald Pfeifer June 15, 2019, 9:37 p.m. | #2
On Mon, 10 Jun 2019, Martin Liška wrote:
> I'm fine with the Gerald. Thank you for it.


I went ahead and committed this, thanks.  

Sandra, if you have any comments still happy to update.

Gerald

Patch

Index: doc/extend.texi
===================================================================
--- doc/extend.texi	(revision 272089)
+++ doc/extend.texi	(working copy)
@@ -3215,9 +3215,9 @@  marked symbols.
 @item no_sanitize ("@var{sanitize_option}")
 @cindex @code{no_sanitize} function attribute
 The @code{no_sanitize} attribute on functions is used
-to inform the compiler that it should not do sanitization of all options
+to inform the compiler that it should not do sanitization of any option
 mentioned in @var{sanitize_option}.  A list of values acceptable by
-@option{-fsanitize} option can be provided.
+the @option{-fsanitize} option can be provided.
 
 @smallexample
 void __attribute__ ((no_sanitize ("alignment", "object-size")))