Remove extraneous parentheses in arm-dis.c

Message ID 20190604122244.46339-1-alan.hayward@arm.com
State New
Headers show
Series
  • Remove extraneous parentheses in arm-dis.c
Related show

Commit Message

Alan Hayward June 4, 2019, 12:22 p.m.
When using llvm as the compiler, it errors with:
error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
	if ((Qd == Qn))

opcodes/ChangeLog:

2019-06-04  Alan Hayward  <alan.hayward@arm.com>

	* arm-dis.c (is_mve_unpredictable):
---
 opcodes/arm-dis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1 (Apple Git-117)

Comments

Nick Clifton June 4, 2019, 1:26 p.m. | #1
Hi Alan,

> opcodes/ChangeLog:

> 2019-06-04  Alan Hayward  <alan.hayward@arm.com>

> 

>	* arm-dis.c (is_mve_unpredictable): Remove spurious paranthesis


Patch applied.

Cheers
  Nick

Patch

diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index 0503d9365d..03aebb571a 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -6619,7 +6619,7 @@  is_mve_unpredictable (unsigned long given, enum mve_instructions matched_insn,
 	      = arm_decode_field_multiple (given, 13, 15, 22, 22);
 	    unsigned long Qn = arm_decode_field_multiple (given, 17, 19, 7, 7);
 
-	    if ((Qd == Qn))
+	    if (Qd == Qn)
 	      {
 		*unpredictable_code = UNPRED_Q_REGS_EQ_AND_SIZE_1;
 		return TRUE;