Fix ICE in resolve_args_picking_1 with -gsplit-dwarf

Message ID 3530053.ohGVArVget@polaris
State New
Headers show
Series
  • Fix ICE in resolve_args_picking_1 with -gsplit-dwarf
Related show

Commit Message

Eric Botcazou May 27, 2019, 8:32 a.m.
The function simply doesn't handle the new location expression opcodes coming 
from DebugFission (https://gcc.gnu.org/wiki/DebugFission).  Fixed by making it 
handle them like DW_OP_addr and DW_OP_const*.

OK for mainline and the active branches (it's a regression from GCC 5)?


2019-05-27  Eric Botcazou  <ebotcazou@adacore.com>

	* dwarf2out.c (resolve_args_picking_1): Deal with DW_OP_GNU_addr_index
	and DW_OP_GNU_const_index opcodes.


2019-05-27  Eric Botcazou  <ebotcazou@adacore.com>

	* gnat.dg/specs/array4.ads: New test.

-- 
Eric Botcazou

Comments

Richard Biener May 27, 2019, 1:58 p.m. | #1
On Mon, May 27, 2019 at 10:32 AM Eric Botcazou <ebotcazou@adacore.com> wrote:
>

> The function simply doesn't handle the new location expression opcodes coming

> from DebugFission (https://gcc.gnu.org/wiki/DebugFission).  Fixed by making it

> handle them like DW_OP_addr and DW_OP_const*.

>

> OK for mainline and the active branches (it's a regression from GCC 5)?


OK.

>

> 2019-05-27  Eric Botcazou  <ebotcazou@adacore.com>

>

>         * dwarf2out.c (resolve_args_picking_1): Deal with DW_OP_GNU_addr_index

>         and DW_OP_GNU_const_index opcodes.

>

>

> 2019-05-27  Eric Botcazou  <ebotcazou@adacore.com>

>

>         * gnat.dg/specs/array4.ads: New test.

>

> --

> Eric Botcazou

Patch

Index: dwarf2out.c
===================================================================
--- dwarf2out.c	(revision 271106)
+++ dwarf2out.c	(working copy)
@@ -17906,6 +17906,8 @@  resolve_args_picking_1 (dw_loc_descr_ref
 	case DW_OP_push_object_address:
 	case DW_OP_call_frame_cfa:
 	case DW_OP_GNU_variable_value:
+	case DW_OP_GNU_addr_index:
+	case DW_OP_GNU_const_index:
 	  ++frame_offset_;
 	  break;