libstdc++-v3: Check for TLS support on mingw

Message ID 1519030763.2942755.1275455464.4F3B5B67@webmail.messagingengine.com
State New
Headers show
Series
  • libstdc++-v3: Check for TLS support on mingw
Related show

Commit Message

Hugo Beauzée-Luyssen Feb. 19, 2018, 8:59 a.m.
libstdc++-v3: Check for TLS support on mingw

2018-02-16  Hugo Beauzée-Luyssen  <hugo@beauzee.fr>

    * crossconfig.m4: Check for TLS support on mignw
    * configure: regenerate

Comments

Jonathan Wakely Feb. 26, 2018, 9:04 p.m. | #1
Apologies if you get this mail multiple times, I'm having some trouble
sending mail to @gcc.gnu.org lists.



On 19/02/18 09:59 +0100, Hugo Beauzée-Luyssen wrote:
> libstdc++-v3: Check for TLS support on mingw

>

> 2018-02-16  Hugo Beauzée-Luyssen  <hugo@beauzee.fr>

>

>    * crossconfig.m4: Check for TLS support on mignw


Typo "minwg"

>    * configure: regenerate

>

> Index: libstdc++-v3/crossconfig.m4

> ===================================================================

> --- libstdc++-v3/crossconfig.m4 (revision 257730)

> +++ libstdc++-v3/crossconfig.m4 (working copy)

> @@ -197,6 +197,7 @@ case "${host}" in

>     GLIBCXX_CHECK_LINKER_FEATURES

>     GLIBCXX_CHECK_MATH_SUPPORT

>     GLIBCXX_CHECK_STDLIB_SUPPORT

> +    GCC_CHECK_TLS

>     ;;

>   *-netbsd*)

>     SECTION_FLAGS='-ffunction-sections -fdata-sections'


Hi, thanks for the patch. I don't think we can apply it now, as the
GCC trunk is only open for regression fixes until GCC 8 is released.

How was this tested? Will it work for all versions of mingw that we
support? Is TLS enabled for native builds? (If so we definitely need
this, because otherwise mingw cross-compilers are not ABI compatibnle
with native ones).

Patch

Index: libstdc++-v3/crossconfig.m4
===================================================================
--- libstdc++-v3/crossconfig.m4 (revision 257730)
+++ libstdc++-v3/crossconfig.m4 (working copy)
@@ -197,6 +197,7 @@  case "${host}" in
     GLIBCXX_CHECK_LINKER_FEATURES
     GLIBCXX_CHECK_MATH_SUPPORT
     GLIBCXX_CHECK_STDLIB_SUPPORT
+    GCC_CHECK_TLS
     ;;
   *-netbsd*)
     SECTION_FLAGS='-ffunction-sections -fdata-sections'