Fix PR84399

Message ID alpine.LSU.2.20.1802160914530.18265@zhemvz.fhfr.qr
State New
Headers show
Series
  • Fix PR84399
Related show

Commit Message

Richard Biener Feb. 16, 2018, 8:15 a.m.
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied.

Richard.

2018-02-16  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/84399
	* graphite-scop-detection.c (scop_detection::stmt_simple_for_scop_p):
	For operands we can analyze at their definition make sure we can
	analyze them at each use as well.

	* gcc.dg/graphite/pr84399.c: New testcase.

Comments

Szabolcs Nagy Feb. 19, 2018, 2:48 p.m. | #1
On 16/02/18 08:15, Richard Biener wrote:
> 

> Bootstrapped and tested on x86_64-unknown-linux-gnu, applied.

> 

> Richard.

> 

> 2018-02-16  Richard Biener  <rguenther@suse.de>

> 

> 	PR tree-optimization/84399

> 	* graphite-scop-detection.c (scop_detection::stmt_simple_for_scop_p):

> 	For operands we can analyze at their definition make sure we can

> 	analyze them at each use as well.

> 

> 	* gcc.dg/graphite/pr84399.c: New testcase.

> 


since this commit (r257723) i see

FAIL: libgomp.graphite/force-parallel-8.c scan-tree-dump-times graphite "5 loops carried no dependency" 1 (found 0 times)

on aarch64-none-linux-gnu and arm-none-linux-gnueabihf

Patch

Index: gcc/graphite-scop-detection.c
===================================================================
--- gcc/graphite-scop-detection.c	(revision 257682)
+++ gcc/graphite-scop-detection.c	(working copy)
@@ -1027,7 +1027,23 @@  scop_detection::stmt_simple_for_scop_p (
 
     case GIMPLE_ASSIGN:
     case GIMPLE_CALL:
-      return true;
+      {
+	tree op;
+	ssa_op_iter i;
+	/* Verify that if we can analyze operands at their def site we
+	   also can represent them when analyzed at their uses.  */
+	FOR_EACH_SSA_TREE_OPERAND (op, stmt, i, SSA_OP_USE)
+	  if (scev_analyzable_p (op, scop)
+	      && !graphite_can_represent_expr (scop, bb->loop_father, op))
+	    {
+	      DEBUG_PRINT (dp << "[scop-detection-fail] "
+			   << "Graphite cannot represent stmt:\n";
+			   print_gimple_stmt (dump_file, stmt, 0,
+					      TDF_VOPS | TDF_MEMSYMS));
+	      return false;
+	    }
+	return true;
+      }
 
     default:
       /* These nodes cut a new scope.  */
Index: gcc/testsuite/gcc.dg/graphite/pr84399.c
===================================================================
--- gcc/testsuite/gcc.dg/graphite/pr84399.c	(nonexistent)
+++ gcc/testsuite/gcc.dg/graphite/pr84399.c	(working copy)
@@ -0,0 +1,23 @@ 
+/* { dg-do compile } */
+/* { dg-options "-O2 -floop-nest-optimize -fno-tree-loop-im --param scev-max-expr-size=1" } */
+
+void
+h8 (int cv, int od)
+{
+  for (;;)
+    {
+      int ih = (__UINTPTR_TYPE__)&od;
+      if (cv == 0)
+	while (od < 1)
+	  {
+	    int lq;
+
+	    for (lq = 0; lq < 3; ++lq)
+	      for (ih = 0; ih < 4; ++ih)
+		od += lq;
+	  }
+      while (ih < 1)
+	{
+	}
+    }
+}