[testsuite] Correct spelling of executable in test_build_id_debuglink

Message ID VI1PR0801MB20144AF81EF25A58C6B470A4E03B0@VI1PR0801MB2014.eurprd08.prod.outlook.com
State New
Headers show
Series
  • [testsuite] Correct spelling of executable in test_build_id_debuglink
Related show

Commit Message

Matthew Malcomson May 1, 2019, 10:21 a.m.
This flag determines what flags the binary is built with.

With an incorrect spelling those extra flags are not added.

Tested with aarch64-none-elf regression test.

If Ok for trunk could someone apply it for me since I don't have commit rights.

binutils/ChangeLog:

2019-05-01  Matthew Malcomson  <matthew.malcomson@arm.com>

	* testsuite/binutils-all/objdump.exp: Correct spelling.



###############     Attachment also inlined for ease of reply    ###############
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index 81a061f70c1f8d9131aa570a86a4f2804400f761..94ff015020b77ce61f3eb9027660bbbb3419eacb 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -526,7 +526,7 @@ proc test_build_id_debuglink {} {
     }
     set CFLAGS_FOR_TARGET "-g -Wl,--build-id=0x12345678abcdef01"
 
-    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
+    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != "" } {
 	unsupported "$test (build)"
 	return
     }

Comments

Matthew Malcomson May 1, 2019, 10:45 a.m. | #1
> This flag determines what flags the binary is built with.

> 

> With an incorrect spelling those extra flags are not added.

> 

> Tested with aarch64-none-elf regression test.

> 

> If Ok for trunk could someone apply it for me since I don't have commit rights.

> 

> binutils/ChangeLog:

> 

> 2019-05-01  Matthew Malcomson  <matthew.malcomson@arm.com>

> 

> 	* testsuite/binutils-all/objdump.exp: Correct spelling.

> 

> 

> 

> ###############     Attachment also inlined for ease of reply    ###############

> 

> 

> diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp

> index 81a061f70c1f8d9131aa570a86a4f2804400f761..94ff015020b77ce61f3eb9027660bbbb3419eacb 100644

> --- a/binutils/testsuite/binutils-all/objdump.exp

> +++ b/binutils/testsuite/binutils-all/objdump.exp

> @@ -526,7 +526,7 @@ proc test_build_id_debuglink {} {

>      }

>      set CFLAGS_FOR_TARGET "-g -Wl,--build-id=0x12345678abcdef01"

>  

> -    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {

> +    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != "" } {

>  	unsupported "$test (build)"

>  	return

>      }

> 


I just noticed the same problem in test_gnu_debuglink, so I'd suggest the below
patch.

binutils/ChangeLog:

2019-05-01  Matthew Malcomson  <matthew.malcomson@arm.com>

	* testsuite/binutils-all/objdump.exp: Correct executable spelling.
	* testsuite/binutils-all/compress.exp: Likewise.



###############     Attachment also inlined for ease of reply    ###############


diff --git a/binutils/testsuite/binutils-all/compress.exp b/binutils/testsuite/binutils-all/compress.exp
index a38e1320801bcf2a12532ecdec1015df15dbfdac..7d50ef506a6d68570389bec7a7a070192b125a2a 100644
--- a/binutils/testsuite/binutils-all/compress.exp
+++ b/binutils/testsuite/binutils-all/compress.exp
@@ -683,7 +683,7 @@ proc test_gnu_debuglink {} {
 
     set test "gnu-debuglink"
 
-    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
+    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != "" } {
 	unsupported "$test (build)"
 	return
     }
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index 81a061f70c1f8d9131aa570a86a4f2804400f761..94ff015020b77ce61f3eb9027660bbbb3419eacb 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -526,7 +526,7 @@ proc test_build_id_debuglink {} {
     }
     set CFLAGS_FOR_TARGET "-g -Wl,--build-id=0x12345678abcdef01"
 
-    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
+    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != "" } {
 	unsupported "$test (build)"
 	return
     }
diff --git a/binutils/testsuite/binutils-all/compress.exp b/binutils/testsuite/binutils-all/compress.exp
index a38e1320801bcf2a12532ecdec1015df15dbfdac..7d50ef506a6d68570389bec7a7a070192b125a2a 100644
--- a/binutils/testsuite/binutils-all/compress.exp
+++ b/binutils/testsuite/binutils-all/compress.exp
@@ -683,7 +683,7 @@ proc test_gnu_debuglink {} {
 
     set test "gnu-debuglink"
 
-    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
+    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != "" } {
 	unsupported "$test (build)"
 	return
     }
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index 81a061f70c1f8d9131aa570a86a4f2804400f761..94ff015020b77ce61f3eb9027660bbbb3419eacb 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -526,7 +526,7 @@ proc test_build_id_debuglink {} {
     }
     set CFLAGS_FOR_TARGET "-g -Wl,--build-id=0x12345678abcdef01"
 
-    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
+    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != "" } {
 	unsupported "$test (build)"
 	return
     }
Nick Clifton May 1, 2019, 3:55 p.m. | #2
Hi Matthew,

> binutils/ChangeLog:

> 2019-05-01  Matthew Malcomson  <matthew.malcomson@arm.com>

> 

> 	* testsuite/binutils-all/objdump.exp: Correct executable spelling.

> 	* testsuite/binutils-all/compress.exp: Likewise.


Approved and applied.  Thanks for reporting this bug!

Cheers
  Nick

Patch

diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index 81a061f70c1f8d9131aa570a86a4f2804400f761..94ff015020b77ce61f3eb9027660bbbb3419eacb 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -526,7 +526,7 @@  proc test_build_id_debuglink {} {
     }
     set CFLAGS_FOR_TARGET "-g -Wl,--build-id=0x12345678abcdef01"
 
-    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
+    if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != "" } {
 	unsupported "$test (build)"
 	return
     }