elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now

Message ID 87wojhan2c.fsf@oldenburg2.str.redhat.com
State New
Headers show
Series
  • elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now
Related show

Commit Message

Florian Weimer April 25, 2019, 7:42 p.m.
The audit module itself can be linked with BIND_NOW; it does not
affect its functionality.

This should complete the leftovers from commit
2d6ab5df3b675e96ee587ae6a8c2ce004c6b1ba9 ("Document and fix
--enable-bind-now [BZ #21015]").

2019-04-25  Florian Weimer  <fweimer@redhat.com>

	elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now.
	* elf/Makefile (LDFLAGS-sotruss-lib.so): Set.

Comments

Carlos O'Donell April 25, 2019, 9:17 p.m. | #1
On 4/25/19 3:42 PM, Florian Weimer wrote:
> The audit module itself can be linked with BIND_NOW; it does not

> affect its functionality.


Agreed.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>


> This should complete the leftovers from commit

> 2d6ab5df3b675e96ee587ae6a8c2ce004c6b1ba9 ("Document and fix

> --enable-bind-now [BZ #21015]").

> 

> 2019-04-25  Florian Weimer  <fweimer@redhat.com>

> 

> 	elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now.

> 	* elf/Makefile (LDFLAGS-sotruss-lib.so): Set.

> 

> diff --git a/elf/Makefile b/elf/Makefile

> index 0b4a877880..4895489208 100644

> --- a/elf/Makefile

> +++ b/elf/Makefile

> @@ -125,6 +125,7 @@ install-others += $(inst_auditdir)/sotruss-lib.so

>   install-bin-script += sotruss

>   generated += sotruss

>   libof-sotruss-lib = extramodules

> +LDFLAGS-sotruss-lib.so += $(z-now-$(bind-now))


OK.

>   $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os

>   	$(build-module-asneeded)

>   $(objpfx)sotruss-lib.so: $(common-objpfx)libc.so $(objpfx)ld.so \

> 



-- 
Cheers,
Carlos.

Patch

diff --git a/elf/Makefile b/elf/Makefile
index 0b4a877880..4895489208 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -125,6 +125,7 @@  install-others += $(inst_auditdir)/sotruss-lib.so
 install-bin-script += sotruss
 generated += sotruss
 libof-sotruss-lib = extramodules
+LDFLAGS-sotruss-lib.so += $(z-now-$(bind-now))
 $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os
 	$(build-module-asneeded)
 $(objpfx)sotruss-lib.so: $(common-objpfx)libc.so $(objpfx)ld.so \