rs6000: new vec-s*d-modulo.c tests should require p8vector_hw

Message ID 2515808c-2a17-81fa-c13f-a47ebdc1e210@linux.ibm.com
State New
Headers show
Series
  • rs6000: new vec-s*d-modulo.c tests should require p8vector_hw
Related show

Commit Message

Bill Schmidt Feb. 12, 2019, 2:56 a.m.
Hi,

It turns out that the new tests added today actually require POWER8 hardware at
a minimum, since the vec_vsrad interface requires it.  (Note that requiring
P8 hardware obviates the need to specify -mvsx, so that is now removed.)

Tested on powerpc64le (P9, P8) and powerpc64 (P7) with correct behavior.  Is this
okay for trunk?

Thanks,
Bill


2018-01-11  Bill Schmidt  <wschmidt@linux.ibm.com>

	* gcc.target/powerpc/vec-sld-modulo.c: Require p8vector_hw.
	* gcc.target/powerpc/vec-srad-modulo.c: Likewise.
	* gcc.target/powerpc/vec-srd-modulo.c: Likewise.

Comments

Segher Boessenkool Feb. 12, 2019, 2:17 p.m. | #1
On Mon, Feb 11, 2019 at 08:56:38PM -0600, Bill Schmidt wrote:
> It turns out that the new tests added today actually require POWER8 hardware at

> a minimum, since the vec_vsrad interface requires it.  (Note that requiring

> P8 hardware obviates the need to specify -mvsx, so that is now removed.)

> 

> Tested on powerpc64le (P9, P8) and powerpc64 (P7) with correct behavior.  Is this

> okay for trunk?


Okay if you add -mpower8-vector for these tests.  Thanks,


Segher

Patch

Index: gcc/testsuite/gcc.target/powerpc/vec-sld-modulo.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-sld-modulo.c	(revision 268771)
+++ gcc/testsuite/gcc.target/powerpc/vec-sld-modulo.c	(working copy)
@@ -1,8 +1,8 @@ 
 /* Test that using a character splat to set up a shift-left
    for a doubleword vector works correctly after gimple folding.  */
 
-/* { dg-do run { target { vsx_hw } } } */
-/* { dg-options "-O2 -mvsx" } */
+/* { dg-do run { target { p8vector_hw } } } */
+/* { dg-options "-O2" } */
 
 #include <altivec.h>
 
Index: gcc/testsuite/gcc.target/powerpc/vec-srad-modulo.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-srad-modulo.c	(revision 268771)
+++ gcc/testsuite/gcc.target/powerpc/vec-srad-modulo.c	(working copy)
@@ -1,8 +1,8 @@ 
 /* Test that using a character splat to set up a shift-right algebraic
    for a doubleword vector works correctly after gimple folding.  */
 
-/* { dg-do run { target { vsx_hw } } } */
-/* { dg-options "-O2 -mvsx" } */
+/* { dg-do run { target { p8vector_hw } } } */
+/* { dg-options "-O2" } */
 
 #include <altivec.h>
 
Index: gcc/testsuite/gcc.target/powerpc/vec-srd-modulo.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-srd-modulo.c	(revision 268771)
+++ gcc/testsuite/gcc.target/powerpc/vec-srd-modulo.c	(working copy)
@@ -1,8 +1,8 @@ 
 /* Test that using a character splat to set up a shift-right logical
    for a doubleword vector works correctly after gimple folding.  */
 
-/* { dg-do run { target { vsx_hw } } } */
-/* { dg-options "-O2 -mvsx" } */
+/* { dg-do run { target { p8vector_hw } } } */
+/* { dg-options "-O2" } */
 
 #include <altivec.h>