[20/43] i386: Emulate MMX mmx_umulv4hi3_highpart with SSE

Message ID 20190210001947.27278-21-hjl.tools@gmail.com
State Superseded
Headers show
Series
  • V3: Emulate MMX intrinsics with SSE
Related show

Commit Message

H.J. Lu Feb. 10, 2019, 12:19 a.m.
Emulate MMX mmx_umulv4hi3_highpart with SSE.  Only SSE register source
operand is allowed.

	PR target/89021
	* config/i386/mmx.md (*mmx_umulv4hi3_highpart): Add SSE emulation.
---
 gcc/config/i386/mmx.md | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

-- 
2.20.1

Comments

Uros Bizjak Feb. 10, 2019, 12:12 p.m. | #1
On 2/10/19, H.J. Lu <hjl.tools@gmail.com> wrote:
> Emulate MMX mmx_umulv4hi3_highpart with SSE.  Only SSE register source

> operand is allowed.

>

> 	PR target/89021

> 	* config/i386/mmx.md (*mmx_umulv4hi3_highpart): Add SSE emulation.

> ---

>  gcc/config/i386/mmx.md | 19 ++++++++++++-------

>  1 file changed, 12 insertions(+), 7 deletions(-)

>

> diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md

> index 0d00896127b..0e5bfe6baff 100644

> --- a/gcc/config/i386/mmx.md

> +++ b/gcc/config/i386/mmx.md

> @@ -817,24 +817,29 @@

>  	      (zero_extend:V4SI

>  		(match_operand:V4HI 2 "nonimmediate_operand")))

>  	    (const_int 16))))]

> -  "TARGET_SSE || TARGET_3DNOW_A"

> +  "((TARGET_MMX || TARGET_MMX_WITH_SSE) && TARGET_SSE)

> +   || TARGET_3DNOW_A"


Please change insn condition.

Uros.

>    "ix86_fixup_binary_operands_no_copy (MULT, V4HImode, operands);")

>

>  (define_insn "*mmx_umulv4hi3_highpart"

> -  [(set (match_operand:V4HI 0 "register_operand" "=y")

> +  [(set (match_operand:V4HI 0 "register_operand" "=y,x,Yv")

>  	(truncate:V4HI

>  	  (lshiftrt:V4SI

>  	    (mult:V4SI

>  	      (zero_extend:V4SI

> -		(match_operand:V4HI 1 "nonimmediate_operand" "%0"))

> +		(match_operand:V4HI 1 "nonimmediate_operand" "%0,0,Yv"))

>  	      (zero_extend:V4SI

> -		(match_operand:V4HI 2 "nonimmediate_operand" "ym")))

> +		(match_operand:V4HI 2 "nonimmediate_operand" "ym,x,Yv")))

>  	  (const_int 16))))]

>    "(TARGET_SSE || TARGET_3DNOW_A)

>     && ix86_binary_operator_ok (MULT, V4HImode, operands)"

> -  "pmulhuw\t{%2, %0|%0, %2}"

> -  [(set_attr "type" "mmxmul")

> -   (set_attr "mode" "DI")])

> +  "@

> +   pmulhuw\t{%2, %0|%0, %2}

> +   pmulhuw\t{%2, %0|%0, %2}

> +   vpmulhuw\t{%2, %1, %0|%0, %1, %2}"

> +  [(set_attr "mmx_isa" "native,x64_noavx,x64_avx")

> +   (set_attr "type" "mmxmul,ssemul,ssemul")

> +   (set_attr "mode" "DI,TI,TI")])

>

>  (define_expand "mmx_pmaddwd"

>    [(set (match_operand:V2SI 0 "register_operand")

> --

> 2.20.1

>

>

Patch

diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
index 0d00896127b..0e5bfe6baff 100644
--- a/gcc/config/i386/mmx.md
+++ b/gcc/config/i386/mmx.md
@@ -817,24 +817,29 @@ 
 	      (zero_extend:V4SI
 		(match_operand:V4HI 2 "nonimmediate_operand")))
 	    (const_int 16))))]
-  "TARGET_SSE || TARGET_3DNOW_A"
+  "((TARGET_MMX || TARGET_MMX_WITH_SSE) && TARGET_SSE)
+   || TARGET_3DNOW_A"
   "ix86_fixup_binary_operands_no_copy (MULT, V4HImode, operands);")
 
 (define_insn "*mmx_umulv4hi3_highpart"
-  [(set (match_operand:V4HI 0 "register_operand" "=y")
+  [(set (match_operand:V4HI 0 "register_operand" "=y,x,Yv")
 	(truncate:V4HI
 	  (lshiftrt:V4SI
 	    (mult:V4SI
 	      (zero_extend:V4SI
-		(match_operand:V4HI 1 "nonimmediate_operand" "%0"))
+		(match_operand:V4HI 1 "nonimmediate_operand" "%0,0,Yv"))
 	      (zero_extend:V4SI
-		(match_operand:V4HI 2 "nonimmediate_operand" "ym")))
+		(match_operand:V4HI 2 "nonimmediate_operand" "ym,x,Yv")))
 	  (const_int 16))))]
   "(TARGET_SSE || TARGET_3DNOW_A)
    && ix86_binary_operator_ok (MULT, V4HImode, operands)"
-  "pmulhuw\t{%2, %0|%0, %2}"
-  [(set_attr "type" "mmxmul")
-   (set_attr "mode" "DI")])
+  "@
+   pmulhuw\t{%2, %0|%0, %2}
+   pmulhuw\t{%2, %0|%0, %2}
+   vpmulhuw\t{%2, %1, %0|%0, %1, %2}"
+  [(set_attr "mmx_isa" "native,x64_noavx,x64_avx")
+   (set_attr "type" "mmxmul,ssemul,ssemul")
+   (set_attr "mode" "DI,TI,TI")])
 
 (define_expand "mmx_pmaddwd"
   [(set (match_operand:V2SI 0 "register_operand")