PR24125, Assertion failure with embedded NULs in string

Message ID 20190124231404.GK29797@bubble.grove.modra.org
State New
Headers show
Series
  • PR24125, Assertion failure with embedded NULs in string
Related show

Commit Message

Alan Modra Jan. 24, 2019, 11:14 p.m.
An assertion that can be triggered by user input is wrong, so remove
it.  I believe the embedded NUL would have been accepted before the
PR20902 patch, but that seems like a misfeature to me.

	PR 20902
	PR 24125
	* read.c (stringer): Delete assertion.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/gas/read.c b/gas/read.c
index 3c84d4388c..228fe7a240 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -5364,8 +5364,6 @@  stringer (int bits_appendzero)
 	  if (append_zero)
 	    stringer_append_char (0, bitsize);
 
-	  know (input_line_pointer[-1] == '\"');
-
 #if !defined(NO_LISTING) && defined (OBJ_ELF)
 	  /* In ELF, when gcc is emitting DWARF 1 debugging output, it
 	     will emit .string with a filename in the .debug section