[MIPS] Fix typo in mips_arch_choices for 2.32 branch

Message ID CAKjxQHnAbs+6d4nWULbifEoVQ5h1AZ6sag5yNcy96NF+bxBBLg@mail.gmail.com
State New
Headers show
Series
  • [MIPS] Fix typo in mips_arch_choices for 2.32 branch
Related show

Commit Message

Paul Hua Jan. 20, 2019, 3:04 a.m.
Hi Nick,

The attached patch fix a typo in mips_arch_choices.

ok for 2.32 branch ?

[MIPS] fix typo in mips_arch_choices.

opcodes/
     * mips-dis.c (mips_arch_choices): Fix typo in
     gs464, gs464e and gs264e descriptors.

Comments

Nick Clifton Jan. 21, 2019, 11:46 a.m. | #1
Hi Paul,

> The attached patch fix a typo in mips_arch_choices.

> 

> ok for 2.32 branch ?


> opcodes/

>      * mips-dis.c (mips_arch_choices): Fix typo in

>      gs464, gs464e and gs264e descriptors.


This is fine - patch approved, please apply.

Cheers
  Nick
Paul Hua Jan. 22, 2019, 3:35 a.m. | #2
Hi Nick,

Applied to 2.32 branch.

But, i made a mistake, please delete the branch. Sorry.

The following massage from binutils-cvs@sourceware.org [1]:
-------------------------------------------------------------------------------------------------------------------
[binutils-gdb] Created branch 'binutils-2_32-branch' in namespace 'refs/for'

From: Chenghua Xu <paulhua at sourceware dot org>

To: bfd-cvs at sourceware dot org, gdb-cvs at sourceware dot org
Date: 22 Jan 2019 01:20:10 -0000
Subject: [binutils-gdb] Created branch 'binutils-2_32-branch' in
namespace 'refs/for'

________________________________

The branch 'binutils-2_32-branch' was created in namespace 'refs/for'
pointing to:

 7defee7... [MIPS] fix typo in mips_arch_choices.
---------------------------------------------------------------------------------------------------------------------

[1] https://sourceware.org/ml/binutils-cvs/2019-01/msg00128.html

On Mon, Jan 21, 2019 at 7:46 PM Nick Clifton <nickc@redhat.com> wrote:
>

> Hi Paul,

>

> > The attached patch fix a typo in mips_arch_choices.

> >

> > ok for 2.32 branch ?

>

> > opcodes/

> >      * mips-dis.c (mips_arch_choices): Fix typo in

> >      gs464, gs464e and gs264e descriptors.

>

> This is fine - patch approved, please apply.

>

> Cheers

>   Nick

>

>
Nick Clifton Jan. 23, 2019, 2:48 p.m. | #3
Hi Paul,

> Applied to 2.32 branch.


Hooray.

> But, i made a mistake, please delete the branch. Sorry.

> The following massage from binutils-cvs@sourceware.org [1]:

> -------------------------------------------------------------------------------------------------------------------

> The branch 'binutils-2_32-branch' was created in namespace 'refs/for'


Were you using Gerrit to do this ?

I think that the refs/for namespace is a special feature of gerrit
that it uses to distinguish between patches for review and patches
to be committed.  (But I am neither a git expert, nor a gerrit expert
so I could well be wrong).

Anyway, I could not see any problems with the current 2.32 branch,
nor could I see any new branches with the same or similar name, so
I think that the binutils git repository is OK.

Cheers
  Nick

Patch

commit 562cd71ee65b0f2a90094ee51f3c4d8b670a6d89
Author: Chenghua Xu <paul.hua.gm@gmail.com>
Date:   Sun Jan 20 01:51:30 2019 +0000

    [MIPS] fix typo in mips_arch_choices.
    
    opcodes/
            * mips-dis.c (mips_arch_choices): Fix typo in
            gs464, gs464e and gs264e descriptors.

diff --git a/opcodes/mips-dis.c b/opcodes/mips-dis.c
index 0dd85e3779..0dc437ede4 100644
--- a/opcodes/mips-dis.c
+++ b/opcodes/mips-dis.c
@@ -635,17 +635,17 @@  const struct mips_arch_choice mips_arch_choices[] =
     mips_cp0_names_numeric, NULL, 0, mips_cp1_names_mips3264,
     mips_hwr_names_numeric },
 
-  { "g464",   1, bfd_mach_mips_gs464, CPU_GS464,
+  { "gs464",   1, bfd_mach_mips_gs464, CPU_GS464,
     ISA_MIPS64R2, ASE_LOONGSON_MMI | ASE_LOONGSON_CAM | ASE_LOONGSON_EXT,
     mips_cp0_names_numeric, NULL, 0, mips_cp1_names_mips3264,
     mips_hwr_names_numeric },
 
-  { "g464e",   1, bfd_mach_mips_gs464e, CPU_GS464E,
+  { "gs464e",   1, bfd_mach_mips_gs464e, CPU_GS464E,
     ISA_MIPS64R2, ASE_LOONGSON_MMI | ASE_LOONGSON_CAM | ASE_LOONGSON_EXT
     | ASE_LOONGSON_EXT2, mips_cp0_names_numeric, NULL, 0, mips_cp1_names_mips3264,
     mips_hwr_names_numeric },
 
-  { "g264e",   1, bfd_mach_mips_gs464e, CPU_GS264E,
+  { "gs264e",   1, bfd_mach_mips_gs464e, CPU_GS264E,
     ISA_MIPS64R2, ASE_LOONGSON_MMI | ASE_LOONGSON_CAM | ASE_LOONGSON_EXT
     | ASE_LOONGSON_EXT2 | ASE_MSA | ASE_MSA64, mips_cp0_names_numeric, NULL,
     0, mips_cp1_names_mips3264, mips_hwr_names_numeric },