x86-64: Remove .file directive from snapshot source

Message ID 20181228143451.GA8483@intel.com
State New
Headers show
Series
  • x86-64: Remove .file directive from snapshot source
Related show

Commit Message

H.J. Lu Dec. 28, 2018, 2:34 p.m.
Since snapshot() is implemented in assembly code, .file directive should
be removed.  Otherwise, debugger can't find the snapshot source.  I am
checking it in as an obvious fix.

H.J.
----
	* gcc.target/x86_64/abi/asm-support-darwin.s: Remove .file
	directive.
	* gcc.target/x86_64/abi/asm-support.S: Likewise.
---
 gcc/testsuite/gcc.target/x86_64/abi/asm-support-darwin.s | 1 -
 gcc/testsuite/gcc.target/x86_64/abi/asm-support.S        | 1 -
 2 files changed, 2 deletions(-)

-- 
2.20.1

Comments

H.J. Lu Dec. 28, 2018, 3:12 p.m. | #1
On Fri, Dec 28, 2018 at 06:34:51AM -0800, H.J. Lu wrote:
> Since snapshot() is implemented in assembly code, .file directive should

> be removed.  Otherwise, debugger can't find the snapshot source.  I am

> checking it in as an obvious fix.

> 

> H.J.

> ----

> 	* gcc.target/x86_64/abi/asm-support-darwin.s: Remove .file

> 	directive.

> 	* gcc.target/x86_64/abi/asm-support.S: Likewise.


I missed these.  Checking it in now.

H.J.
---
	* gcc.target/x86_64/abi/avx/asm-support-darwin.s: Remove .file
	directive.
	* gcc.target/x86_64/abi/avx/asm-support.S: Likewise.
	* gcc.target/x86_64/abi/avx512f/asm-support.S: Likewise.
---
 gcc/testsuite/ChangeLog                                      | 3 +++
 gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support-darwin.s | 1 -
 gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S        | 1 -
 gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S    | 1 -
 4 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 7f9d1a509c8..7ebbb0a90d7 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -3,6 +3,9 @@
 	* gcc.target/x86_64/abi/asm-support-darwin.s: Remove .file
 	directive.
 	* gcc.target/x86_64/abi/asm-support.S: Likewise.
+	* gcc.target/x86_64/abi/avx/asm-support-darwin.s: Likewise.
+	* gcc.target/x86_64/abi/avx/asm-support.S: Likewise.
+	* gcc.target/x86_64/abi/avx512f/asm-support.S: Likewise.
 
 2018-12-27  Jan Hubicka  <hubicka@ucw.cz>
 
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support-darwin.s b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support-darwin.s
index c070d65034a..9d87df8426d 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support-darwin.s
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support-darwin.s
@@ -1,4 +1,3 @@
-	.file	"asm-support-darwin.s"
 	.text
 	.p2align 4,,15
 	.globl _snapshot
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
index d248ef02e84..73a59191d6d 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
@@ -1,4 +1,3 @@
-	.file	"snapshot.S"
 	.text
 	.p2align 4,,15
 .globl snapshot
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
index e0309aeac12..0ef82876dd9 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
@@ -1,4 +1,3 @@
-	.file	"snapshot.S"
 	.text
 	.p2align 4,,15
 .globl snapshot
-- 
2.20.1

Patch

diff --git a/gcc/testsuite/gcc.target/x86_64/abi/asm-support-darwin.s b/gcc/testsuite/gcc.target/x86_64/abi/asm-support-darwin.s
index b3b88466a62..8fe5dab5416 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/asm-support-darwin.s
+++ b/gcc/testsuite/gcc.target/x86_64/abi/asm-support-darwin.s
@@ -1,4 +1,3 @@ 
-	.file	"snapshot.S"
 	.text
 	.p2align 4,,15
 .globl _snapshot
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
index 8e0bffe8b49..7a8ed03d119 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
+++ b/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
@@ -1,4 +1,3 @@ 
-	.file	"snapshot.S"
 #ifdef __AVX__
 	.sse_check none
 #endif