[v2,7/7] Fortran: Document scope operator.

Message ID 1542663530-140490-7-git-send-email-pwodkowski@pl.sii.eu
State New
Headers show
Series
  • [v2,1/7] DWARF: Don't add nameless modules to partial symbol table.
Related show

Commit Message

Paweł Wódkowski Nov. 19, 2018, 9:38 p.m.
From: Bernhard Heckel <bernhard.heckel@intel.com>


Document scope operator in GDB manual.

2016-08-10  Bernhard Heckel  <bernhard.heckel@intel.com>

gdb/Changelog:
	* doc/gdb.texinfo (Fortran Operators): Describe scope operator.

Changes from V1 to V2:
	refactored entry in texinfo file, updated commit message.
---
 gdb/doc/gdb.texinfo | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.7.4

Comments

Eli Zaretskii Nov. 20, 2018, 3:30 a.m. | #1
> From: Pawel Wodkowski <pwodkowski@pl.sii.eu>

> Cc: tim.wiederhake@intel.com,	dragos.carciumaru@intel.com,	Bernhard Heckel <bernhard.heckel@intel.com>

> Date: Mon, 19 Nov 2018 22:38:50 +0100

> 

> From: Bernhard Heckel <bernhard.heckel@intel.com>

> 

> Document scope operator in GDB manual.

> 

> 2016-08-10  Bernhard Heckel  <bernhard.heckel@intel.com>

> 

> gdb/Changelog:

> 	* doc/gdb.texinfo (Fortran Operators): Describe scope operator.

> 

> Changes from V1 to V2:

> 	refactored entry in texinfo file, updated commit message.


OK for this part.

Thanks.
Paweł Wódkowski Nov. 22, 2018, 4:13 p.m. | #2
On 20.11.2018 04:30, Eli Zaretskii wrote:
>> From: Pawel Wodkowski <pwodkowski@pl.sii.eu>

>> Cc: tim.wiederhake@intel.com,	dragos.carciumaru@intel.com,	Bernhard Heckel <bernhard.heckel@intel.com>

>> Date: Mon, 19 Nov 2018 22:38:50 +0100

>>

>> From: Bernhard Heckel <bernhard.heckel@intel.com>

>>

>> Document scope operator in GDB manual.

>>

>> 2016-08-10  Bernhard Heckel  <bernhard.heckel@intel.com>

>>

>> gdb/Changelog:

>> 	* doc/gdb.texinfo (Fortran Operators): Describe scope operator.

>>

>> Changes from V1 to V2:

>> 	refactored entry in texinfo file, updated commit message.

> 

> OK for this part.

> 

> Thanks.

> 


This is our first steps in GDB community so thanks for review.

Are we OK to push to all these changes or we need to wait for someone 
else to ack?

Pawel
Eli Zaretskii Nov. 23, 2018, 10:30 a.m. | #3
> From: Paweł Wódkowski <pwodkowski@pl.sii.eu>

> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,

> 	Michał Urbański <murbanski@pl.sii.eu>, "Sebastian

>  Basierski" <sbasierski@pl.sii.eu>, "tim.wiederhake@intel.com"

> 	<tim.wiederhake@intel.com>, "dragos.carciumaru@intel.com"

> 	<dragos.carciumaru@intel.com>, "bernhard.heckel@intel.com"

> 	<bernhard.heckel@intel.com>

> Date: Thu, 22 Nov 2018 16:13:19 +0000

> 

> >> From: Bernhard Heckel <bernhard.heckel@intel.com>

> >>

> >> Document scope operator in GDB manual.

> >>

> >> 2016-08-10  Bernhard Heckel  <bernhard.heckel@intel.com>

> >>

> >> gdb/Changelog:

> >> 	* doc/gdb.texinfo (Fortran Operators): Describe scope operator.

> >>

> >> Changes from V1 to V2:

> >> 	refactored entry in texinfo file, updated commit message.

> > 

> > OK for this part.

> > 

> > Thanks.

> > 

> 

> This is our first steps in GDB community so thanks for review.

> 

> Are we OK to push to all these changes or we need to wait for someone 

> else to ack?


I only approved part 7 of your patch series.  I cannot approve the
rest, so please wait for others to chime in.

Thanks.

Patch

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 944a2c438373..5eb3d6abfee5 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -15882,6 +15882,10 @@  The access component operator.  Normally used to access elements in derived
 types.  Also suitable for unions.  As unions aren't part of regular Fortran,
 this can only happen when accessing a register that uses a gdbarch-defined
 union type.
+@item ::
+The scope operator.  Normally used to access variables in modules or
+to set breakpoints on subroutines nested in modules or in other
+subroutines (internal subroutines).
 @end table
 
 @node Fortran Defaults