[2/2,ARC] Improved robustness. Return FALSE in case of NULL pointer.

Message ID 20181115154631.23211-3-claziss@gmail.com
State New
Headers show
Series
  • ARC 2][COMMITTED] Backports from mainline.
Related show

Commit Message

Claudiu Zissulescu Nov. 15, 2018, 3:46 p.m.
From: Cupertino Miranda <cmiranda@synopsys.com>


bfd/
2018-03-01  Cupertino Miranda <cmiranda@synopsys.com>

	* elf32-arc.c (elf_arc_finish_dynamic_symbol) Return FALSE in case
	arc_htab is NULL.
---
 bfd/ChangeLog   | 7 +++++++
 bfd/elf32-arc.c | 3 +++
 2 files changed, 10 insertions(+)

-- 
2.19.1

Patch

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 8c3654f541..318bf9412c 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@ 
+2018-11-15  Claudiu Zissulescu  <claziss@synopsys.com>
+
+	Backport from mainline
+	2018-03-01  Cupertino Miranda <cmiranda@synopsys.com>
+	* elf32-arc.c (elf_arc_finish_dynamic_symbol) Return FALSE in case
+	arc_htab is NULL.
+
 2018-11-15  Claudiu Zissulescu  <claziss@synopsys.com>
 
 	Backport from mainline
diff --git a/bfd/elf32-arc.c b/bfd/elf32-arc.c
index ab84de4381..1d0b6b8abe 100644
--- a/bfd/elf32-arc.c
+++ b/bfd/elf32-arc.c
@@ -2420,6 +2420,9 @@  elf_arc_finish_dynamic_symbol (bfd * output_bfd,
     {
       struct elf_arc_link_hash_table *arc_htab = elf_arc_hash_table (info);
 
+      if (arc_htab == NULL)
+	return FALSE;
+
       if (h->dynindx == -1
 	  || (h->root.type != bfd_link_hash_defined
 	      && h->root.type != bfd_link_hash_defweak)