Don't use PSEUDO_END for non-PSEUDO function

Message ID mvmva5us2ui.fsf@suse.de
State New
Headers show
Series
  • Don't use PSEUDO_END for non-PSEUDO function
Related show

Commit Message

Andreas Schwab Oct. 22, 2018, 10:16 a.m.
* sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of
	PSEUDO_END.
---
 sysdeps/unix/sysv/linux/riscv/setcontext.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.19.1


-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Comments

Florian Weimer Oct. 22, 2018, 10:57 a.m. | #1
* Andreas Schwab:

> 	* sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of

> 	PSEUDO_END.


Is this just about cosmetics, or does this change fix a bug?

Thanks,
Florian
Andreas Schwab Oct. 22, 2018, 12:05 p.m. | #2
On Okt 22 2018, Florian Weimer <fweimer@redhat.com> wrote:

> * Andreas Schwab:

>

>> 	* sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of

>> 	PSEUDO_END.

>

> Is this just about cosmetics, or does this change fix a bug?


Neither.  PSEUDO_END defines a useless syscall error label.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Palmer Dabbelt Oct. 22, 2018, 7:31 p.m. | #3
On Mon, 22 Oct 2018 03:16:53 PDT (-0700), schwab@suse.de wrote:
> 	* sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of

> 	PSEUDO_END.


I'm terrible with changelogs, but I think this should contain the functions 
that were modified.  I'd have it look like

       * sysdeps/unix/sysv/linux/riscv/setcontext.S (__setcontext): Use END 
         instead of PSEUDO_END.
	 (__start_context): Likewise.

I might be wrong, though.

> ---

>  sysdeps/unix/sysv/linux/riscv/setcontext.S | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/sysdeps/unix/sysv/linux/riscv/setcontext.S b/sysdeps/unix/sysv/linux/riscv/setcontext.S

> index d676fa9329..ed2c38ef2b 100644

> --- a/sysdeps/unix/sysv/linux/riscv/setcontext.S

> +++ b/sysdeps/unix/sysv/linux/riscv/setcontext.S

> @@ -94,7 +94,7 @@ LEAF (__setcontext)

>

>  99:	j	__syscall_error

>

> -PSEUDO_END (__setcontext)

> +END (__setcontext)

>  weak_alias (__setcontext, setcontext)

>

>  LEAF (__start_context)

> @@ -112,4 +112,4 @@ LEAF (__start_context)

>  	jal	__setcontext

>  1:	j	exit

>

> -PSEUDO_END (__start_context)

> +END (__start_context)


Thanks.  Do you commit to glibc or do you want me to?
Andreas Schwab Oct. 23, 2018, 7:43 a.m. | #4
On Okt 22 2018, Palmer Dabbelt <palmer@sifive.com> wrote:

> On Mon, 22 Oct 2018 03:16:53 PDT (-0700), schwab@suse.de wrote:

>> 	* sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of

>> 	PSEUDO_END.

>

> I'm terrible with changelogs, but I think this should contain the

> functions that were modified.  I'd have it look like

>

>       * sysdeps/unix/sysv/linux/riscv/setcontext.S (__setcontext): Use END

> instead of PSEUDO_END.

> 	 (__start_context): Likewise.

>

> I might be wrong, though.


You're right, I should have known better.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Patch

diff --git a/sysdeps/unix/sysv/linux/riscv/setcontext.S b/sysdeps/unix/sysv/linux/riscv/setcontext.S
index d676fa9329..ed2c38ef2b 100644
--- a/sysdeps/unix/sysv/linux/riscv/setcontext.S
+++ b/sysdeps/unix/sysv/linux/riscv/setcontext.S
@@ -94,7 +94,7 @@  LEAF (__setcontext)
 
 99:	j	__syscall_error
 
-PSEUDO_END (__setcontext)
+END (__setcontext)
 weak_alias (__setcontext, setcontext)
 
 LEAF (__start_context)
@@ -112,4 +112,4 @@  LEAF (__start_context)
 	jal	__setcontext
 1:	j	exit
 
-PSEUDO_END (__start_context)
+END (__start_context)