[GAS,ARM] Fix ARMv8.1 AdvSIMD testism

Message ID 5BC9F164.1080509@arm.com
State New
Headers show
Series
  • [GAS,ARM] Fix ARMv8.1 AdvSIMD testism
Related show

Commit Message

Andre Vieira (lists) Oct. 19, 2018, 2:59 p.m.
Hi,

This patch fixes a testism.
This test never used to test the output of objdump as the old 'error-output'
check would exit after verifying the output in stdout and stderr from the
assembler.  Given the use of warning_output now, the objdump runs and
expects
its output to be verified.  Assuming the correct disassembly of these
instructions is tested elsewhere given we never tested them here, this patch
removes the objdump run.

Is this OK for trunk?

gas/ChangeLog

2018-10-19  Andre Vieira  <andre.simoesdiasvieira@arm.com>

        * testsuite/gas/arm/armv8-a+rdma-warning.d: Remove
        objdump execution.

Comments

Thomas Preudhomme Oct. 26, 2018, 10:27 a.m. | #1
Hi Andre,

On Fri, 19 Oct 2018 at 16:00, Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
>

>

> Hi,

>

> This patch fixes a testism.

> This test never used to test the output of objdump as the old 'error-output'

> check would exit after verifying the output in stdout and stderr from the

> assembler.  Given the use of warning_output now, the objdump runs and

> expects

> its output to be verified.  Assuming the correct disassembly of these

> instructions is tested elsewhere given we never tested them here, this patch

> removes the objdump run.


It is indeed in gas/testsuite/gas/arm/armv8-a+rdma.d

Patch therefore looks good to me. I'm not a maintainer though so
you'll need someone else to approve.

Best regards,

Thomas
>

> Is this OK for trunk?

>

> gas/ChangeLog

>

> 2018-10-19  Andre Vieira  <andre.simoesdiasvieira@arm.com>

>

>         * testsuite/gas/arm/armv8-a+rdma-warning.d: Remove

>         objdump execution.
Andre Vieira (lists) Oct. 30, 2018, 11:18 a.m. | #2
On 26/10/18 11:27, Thomas Preudhomme wrote:
> Hi Andre,

> 

> On Fri, 19 Oct 2018 at 16:00, Andre Vieira (lists)

> <Andre.SimoesDiasVieira@arm.com> wrote:

>>

>>

>> Hi,

>>

>> This patch fixes a testism.

>> This test never used to test the output of objdump as the old 'error-output'

>> check would exit after verifying the output in stdout and stderr from the

>> assembler.  Given the use of warning_output now, the objdump runs and

>> expects

>> its output to be verified.  Assuming the correct disassembly of these

>> instructions is tested elsewhere given we never tested them here, this patch

>> removes the objdump run.

> 

> It is indeed in gas/testsuite/gas/arm/armv8-a+rdma.d

> 

> Patch therefore looks good to me. I'm not a maintainer though so

> you'll need someone else to approve.

> 

> Best regards,

> 

> Thomas

>>

>> Is this OK for trunk?

>>

>> gas/ChangeLog

>>

>> 2018-10-19  Andre Vieira  <andre.simoesdiasvieira@arm.com>

>>

>>         * testsuite/gas/arm/armv8-a+rdma-warning.d: Remove

>>         objdump execution.


Ping.
Ramana Radhakrishnan Oct. 30, 2018, 3:30 p.m. | #3
On Fri, Oct 19, 2018 at 4:00 PM Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
>

>

> Hi,

>

> This patch fixes a testism.

> This test never used to test the output of objdump as the old 'error-output'

> check would exit after verifying the output in stdout and stderr from the

> assembler.  Given the use of warning_output now, the objdump runs and

> expects

> its output to be verified.  Assuming the correct disassembly of these

> instructions is tested elsewhere given we never tested them here, this patch

> removes the objdump run.

>

> Is this OK for trunk?

>


OK.

Ramana
> gas/ChangeLog

>

> 2018-10-19  Andre Vieira  <andre.simoesdiasvieira@arm.com>

>

>         * testsuite/gas/arm/armv8-a+rdma-warning.d: Remove

>         objdump execution.

Patch

diff --git a/gas/testsuite/gas/arm/armv8-a+rdma-warning.d b/gas/testsuite/gas/arm/armv8-a+rdma-warning.d
index ee1de5b8a498f363d13c6448ac6af7353ad20885..f5fffb18225d55f1a512f759dd1eb17059ca764b 100644
--- a/gas/testsuite/gas/arm/armv8-a+rdma-warning.d
+++ b/gas/testsuite/gas/arm/armv8-a+rdma-warning.d
@@ -1,6 +1,5 @@ 
 #name: Accepted v8-a with ARMv8.1 AdvSIMD.
 #as: -march=armv8-a+simd
-#objdump: -dr
 #skip: *-*-pe *-*-wince
 #source: armv8-a+rdma.s
 #warning_output: armv8-a+rdma.l