Build only shared libnsl objects if NIS is disabled (bug 22701)

Message ID 878tckxzph.fsf@linux-m68k.org
State New
Headers show
Series
  • Build only shared libnsl objects if NIS is disabled (bug 22701)
Related show

Commit Message

Andreas Schwab Jan. 26, 2018, 6:05 p.m.
[BZ #22701]
	* nis/Makefile (libnsl-inhibit-o) [$(build-obsolete-nsl) != yes]:
	Build only shared objects.

-- 
2.16.1


-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Comments

Florian Weimer Jan. 26, 2018, 6:12 p.m. | #1
On 01/26/2018 07:05 PM, Andreas Schwab wrote:
> -libnsl-inhibit-o = .o # Build no static libnsl.a.

> +# Build only shared libnsl.

> +libnsl-inhibit-o = $(filter-out .os,$(object-suffixes))


Why is this change needed?  Is it about --enable-profile builds?

Thanks,
Florian
Andreas Schwab Jan. 26, 2018, 7:50 p.m. | #2
On Jan 26 2018, Florian Weimer <fweimer@redhat.com> wrote:

> On 01/26/2018 07:05 PM, Andreas Schwab wrote:

>> -libnsl-inhibit-o = .o # Build no static libnsl.a.

>> +# Build only shared libnsl.

>> +libnsl-inhibit-o = $(filter-out .os,$(object-suffixes))

>

> Why is this change needed?  Is it about --enable-profile builds?


Yes.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Patch

diff --git a/nis/Makefile b/nis/Makefile
index 01ec4dc357..e7497f7242 100644
--- a/nis/Makefile
+++ b/nis/Makefile
@@ -74,7 +74,8 @@  else # not $(build-obsolete-nsl)
 # is not installed.
 install-lib-ldscripts = libnsl.so
 $(inst_libdir)/libnsl.so:
-libnsl-inhibit-o = .o # Build no static libnsl.a.
+# Build only shared libnsl.
+libnsl-inhibit-o = $(filter-out .os,$(object-suffixes))
 
 endif # not $(build-obsolete-nsl)