[v2,00/12] Fix Ravenscar regressions

Message ID 20200805190841.2506771-1-tromey@adacore.com
Headers show
Series
  • Fix Ravenscar regressions
Related show

Message

Tom Tromey Aug. 5, 2020, 7:08 p.m.
Some changes in gdb caused regressions in AdaCore's internal Ravenscar
testing.  This is understandable, because a Ravenscar environment is a
bit of a pain to set up, and so I don't think it's tested in ordinary
gdb testing.

This series is v2 of some fixes to Ravenscar.  A few more fixes have
been added since the last series, to cope with new regressions.  I've
also dropped the "random thread switch" patch from the series.  I hope
we can discuss that one again sometime, but meanwhile I'd rather get
these changes in.

Tom

Comments

Joel Brobecker Aug. 7, 2020, 3:03 p.m. | #1
Hi Tom,

> Some changes in gdb caused regressions in AdaCore's internal Ravenscar

> testing.  This is understandable, because a Ravenscar environment is a

> bit of a pain to set up, and so I don't think it's tested in ordinary

> gdb testing.

> 

> This series is v2 of some fixes to Ravenscar.  A few more fixes have

> been added since the last series, to cope with new regressions.  I've

> also dropped the "random thread switch" patch from the series.  I hope

> we can discuss that one again sometime, but meanwhile I'd rather get

> these changes in.


I can't approve the documentation bits, but the rest of the patch
series looks good to me.

Thank you!
-- 
Joel
Tom Tromey Aug. 7, 2020, 4:26 p.m. | #2
>> This series is v2 of some fixes to Ravenscar.  A few more fixes have

>> been added since the last series, to cope with new regressions.  I've

>> also dropped the "random thread switch" patch from the series.  I hope

>> we can discuss that one again sometime, but meanwhile I'd rather get

>> these changes in.


Joel> I can't approve the documentation bits, but the rest of the patch
Joel> series looks good to me.

Thanks.  The documentation patch was actually approved here (with one
change, which is included in this update):

https://sourceware.org/pipermail/gdb-patches/2019-March/156463.html

So, I am going to check in this series.

Tom
Eli Zaretskii Aug. 7, 2020, 5:11 p.m. | #3
> Date: Fri, 7 Aug 2020 08:03:12 -0700

> From: Joel Brobecker <brobecker@adacore.com>

> 

> I can't approve the documentation bits, but the rest of the patch

> series looks good to me.


The documentation part is also OK.

Thanks.