[PATCHv2,00/18] Further updates for the language class structure

Message ID cover.1596638295.git.andrew.burgess@embecosm.com
Headers show
Series
  • Further updates for the language class structure
Related show

Message

Andrew Burgess Aug. 5, 2020, 2:45 p.m.
This v2 series replaces, and extends the earlier series I posted here:

    https://sourceware.org/pipermail/gdb-patches/2020-July/170288.html

The first 10 patches are the same as the previous series, while the
remaining 8 are new in this version of the series.

After this series the language_data base class is completely removed.

As I mentioned in the original patch series, I'm not 100% sure that
converting static data fields from language_data into virtual methods
on language_defn is the right approach, but getting rid of
language_data does feel like a good thing, so I pushed through and
completed the task.

I'd be interested in any feedback, do people think this is the right
approach, or are there any suggestions for a better approach.

Thanks,
Andrew

---

Andrew Burgess (18):
  gdb: Convert la_struct_too_deep_ellipsis to a method
  gdb: Convert la_name_of_this to a method
  gdb: Convert la_name and la_natural_name to methods
  gdb: Convert la_filename_extensions to a method
  gdb: Move la_language into the language_defn class
  gdb: Convert language_data::c_style_arrays to a method
  gdb: Fix an incorrect comment
  gdb: Convert language_data::string_lower_bound to a method
  gdb: Convert la_store_sym_names_in_linkage_form_p to a method
  gdb: Override store_sym_names_in_linkage_form_p for Go language
  gdb: Convert language_data::la_range_check to a method
  gdb: Convert language_data::la_case_sensitivity to a method
  gdb: Convert language_data::la_array_ordering to a method
  gdb: Convert language_data::la_macro_expansion to a method
  gdb: Convert language_data::la_varobj_ops to a method
  gdb: Convert language_data::la_exp_desc to a method
  gdb: Convert language_data::la_op_print_tab to a method
  gdb: Remove language_data struct

 gdb/ChangeLog         | 627 ++++++++++++++++++++++++++++++++++++++++++
 gdb/ada-lang.c        |  78 ++++--
 gdb/ax-gdb.c          |   2 +-
 gdb/c-exp.y           |   2 +-
 gdb/c-lang.c          | 268 ++++++++++--------
 gdb/compile/compile.c |   2 +-
 gdb/cp-valprint.c     |   4 +-
 gdb/d-lang.c          |  62 +++--
 gdb/dwarf2/read.c     |  10 +-
 gdb/eval.c            |   4 +-
 gdb/expprint.c        |  22 +-
 gdb/f-lang.c          |  87 ++++--
 gdb/go-lang.c         |  48 ++--
 gdb/infcall.c         |   2 +-
 gdb/language.c        | 186 ++++++++-----
 gdb/language.h        | 238 ++++++++--------
 gdb/m2-lang.c         |  60 ++--
 gdb/mi/mi-cmd-var.c   |   2 +-
 gdb/objc-lang.c       |  62 +++--
 gdb/opencl-lang.c     |  48 ++--
 gdb/p-lang.c          |  63 +++--
 gdb/parse.c           |   9 +-
 gdb/rust-lang.c       |  62 +++--
 gdb/symfile.c         |   1 +
 gdb/symtab.c          |  10 +-
 gdb/valarith.c        |   6 +-
 gdb/valops.c          |  14 +-
 gdb/valprint.c        |   4 +-
 gdb/value.c           |   7 +-
 gdb/varobj.c          |   2 +-
 gdb/varobj.h          |   2 -
 31 files changed, 1395 insertions(+), 599 deletions(-)

-- 
2.25.4

Comments

Andrew Burgess Sept. 3, 2020, 4 p.m. | #1
I'm going to take a look at rebasing and merging this series in the
next few days.  There's no functional change, it's just more movement
away from using the original language structure.

Any last minute feedback?

Thanks,
Andrew


* Andrew Burgess <andrew.burgess@embecosm.com> [2020-08-05 15:45:35 +0100]:

> This v2 series replaces, and extends the earlier series I posted here:

> 

>     https://sourceware.org/pipermail/gdb-patches/2020-July/170288.html

> 

> The first 10 patches are the same as the previous series, while the

> remaining 8 are new in this version of the series.

> 

> After this series the language_data base class is completely removed.

> 

> As I mentioned in the original patch series, I'm not 100% sure that

> converting static data fields from language_data into virtual methods

> on language_defn is the right approach, but getting rid of

> language_data does feel like a good thing, so I pushed through and

> completed the task.

> 

> I'd be interested in any feedback, do people think this is the right

> approach, or are there any suggestions for a better approach.

> 

> Thanks,

> Andrew

> 

> ---

> 

> Andrew Burgess (18):

>   gdb: Convert la_struct_too_deep_ellipsis to a method

>   gdb: Convert la_name_of_this to a method

>   gdb: Convert la_name and la_natural_name to methods

>   gdb: Convert la_filename_extensions to a method

>   gdb: Move la_language into the language_defn class

>   gdb: Convert language_data::c_style_arrays to a method

>   gdb: Fix an incorrect comment

>   gdb: Convert language_data::string_lower_bound to a method

>   gdb: Convert la_store_sym_names_in_linkage_form_p to a method

>   gdb: Override store_sym_names_in_linkage_form_p for Go language

>   gdb: Convert language_data::la_range_check to a method

>   gdb: Convert language_data::la_case_sensitivity to a method

>   gdb: Convert language_data::la_array_ordering to a method

>   gdb: Convert language_data::la_macro_expansion to a method

>   gdb: Convert language_data::la_varobj_ops to a method

>   gdb: Convert language_data::la_exp_desc to a method

>   gdb: Convert language_data::la_op_print_tab to a method

>   gdb: Remove language_data struct

> 

>  gdb/ChangeLog         | 627 ++++++++++++++++++++++++++++++++++++++++++

>  gdb/ada-lang.c        |  78 ++++--

>  gdb/ax-gdb.c          |   2 +-

>  gdb/c-exp.y           |   2 +-

>  gdb/c-lang.c          | 268 ++++++++++--------

>  gdb/compile/compile.c |   2 +-

>  gdb/cp-valprint.c     |   4 +-

>  gdb/d-lang.c          |  62 +++--

>  gdb/dwarf2/read.c     |  10 +-

>  gdb/eval.c            |   4 +-

>  gdb/expprint.c        |  22 +-

>  gdb/f-lang.c          |  87 ++++--

>  gdb/go-lang.c         |  48 ++--

>  gdb/infcall.c         |   2 +-

>  gdb/language.c        | 186 ++++++++-----

>  gdb/language.h        | 238 ++++++++--------

>  gdb/m2-lang.c         |  60 ++--

>  gdb/mi/mi-cmd-var.c   |   2 +-

>  gdb/objc-lang.c       |  62 +++--

>  gdb/opencl-lang.c     |  48 ++--

>  gdb/p-lang.c          |  63 +++--

>  gdb/parse.c           |   9 +-

>  gdb/rust-lang.c       |  62 +++--

>  gdb/symfile.c         |   1 +

>  gdb/symtab.c          |  10 +-

>  gdb/valarith.c        |   6 +-

>  gdb/valops.c          |  14 +-

>  gdb/valprint.c        |   4 +-

>  gdb/value.c           |   7 +-

>  gdb/varobj.c          |   2 +-

>  gdb/varobj.h          |   2 -

>  31 files changed, 1395 insertions(+), 599 deletions(-)

> 

> -- 

> 2.25.4

>
Andrew Burgess Sept. 16, 2020, 10:06 a.m. | #2
I've now pushed this series.

Any post-commit feedback is still always welcome.

Thanks,
Andrew


* Andrew Burgess <andrew.burgess@embecosm.com> [2020-09-03 17:00:34 +0100]:

> I'm going to take a look at rebasing and merging this series in the

> next few days.  There's no functional change, it's just more movement

> away from using the original language structure.

> 

> Any last minute feedback?

> 

> Thanks,

> Andrew

> 

> 

> * Andrew Burgess <andrew.burgess@embecosm.com> [2020-08-05 15:45:35 +0100]:

> 

> > This v2 series replaces, and extends the earlier series I posted here:

> > 

> >     https://sourceware.org/pipermail/gdb-patches/2020-July/170288.html

> > 

> > The first 10 patches are the same as the previous series, while the

> > remaining 8 are new in this version of the series.

> > 

> > After this series the language_data base class is completely removed.

> > 

> > As I mentioned in the original patch series, I'm not 100% sure that

> > converting static data fields from language_data into virtual methods

> > on language_defn is the right approach, but getting rid of

> > language_data does feel like a good thing, so I pushed through and

> > completed the task.

> > 

> > I'd be interested in any feedback, do people think this is the right

> > approach, or are there any suggestions for a better approach.

> > 

> > Thanks,

> > Andrew

> > 

> > ---

> > 

> > Andrew Burgess (18):

> >   gdb: Convert la_struct_too_deep_ellipsis to a method

> >   gdb: Convert la_name_of_this to a method

> >   gdb: Convert la_name and la_natural_name to methods

> >   gdb: Convert la_filename_extensions to a method

> >   gdb: Move la_language into the language_defn class

> >   gdb: Convert language_data::c_style_arrays to a method

> >   gdb: Fix an incorrect comment

> >   gdb: Convert language_data::string_lower_bound to a method

> >   gdb: Convert la_store_sym_names_in_linkage_form_p to a method

> >   gdb: Override store_sym_names_in_linkage_form_p for Go language

> >   gdb: Convert language_data::la_range_check to a method

> >   gdb: Convert language_data::la_case_sensitivity to a method

> >   gdb: Convert language_data::la_array_ordering to a method

> >   gdb: Convert language_data::la_macro_expansion to a method

> >   gdb: Convert language_data::la_varobj_ops to a method

> >   gdb: Convert language_data::la_exp_desc to a method

> >   gdb: Convert language_data::la_op_print_tab to a method

> >   gdb: Remove language_data struct

> > 

> >  gdb/ChangeLog         | 627 ++++++++++++++++++++++++++++++++++++++++++

> >  gdb/ada-lang.c        |  78 ++++--

> >  gdb/ax-gdb.c          |   2 +-

> >  gdb/c-exp.y           |   2 +-

> >  gdb/c-lang.c          | 268 ++++++++++--------

> >  gdb/compile/compile.c |   2 +-

> >  gdb/cp-valprint.c     |   4 +-

> >  gdb/d-lang.c          |  62 +++--

> >  gdb/dwarf2/read.c     |  10 +-

> >  gdb/eval.c            |   4 +-

> >  gdb/expprint.c        |  22 +-

> >  gdb/f-lang.c          |  87 ++++--

> >  gdb/go-lang.c         |  48 ++--

> >  gdb/infcall.c         |   2 +-

> >  gdb/language.c        | 186 ++++++++-----

> >  gdb/language.h        | 238 ++++++++--------

> >  gdb/m2-lang.c         |  60 ++--

> >  gdb/mi/mi-cmd-var.c   |   2 +-

> >  gdb/objc-lang.c       |  62 +++--

> >  gdb/opencl-lang.c     |  48 ++--

> >  gdb/p-lang.c          |  63 +++--

> >  gdb/parse.c           |   9 +-

> >  gdb/rust-lang.c       |  62 +++--

> >  gdb/symfile.c         |   1 +

> >  gdb/symtab.c          |  10 +-

> >  gdb/valarith.c        |   6 +-

> >  gdb/valops.c          |  14 +-

> >  gdb/valprint.c        |   4 +-

> >  gdb/value.c           |   7 +-

> >  gdb/varobj.c          |   2 +-

> >  gdb/varobj.h          |   2 -

> >  31 files changed, 1395 insertions(+), 599 deletions(-)

> > 

> > -- 

> > 2.25.4

> >