[0/8] OpenRISC BFD fixups for Glibc

Message ID 20200514210018.2749462-1-shorne@gmail.com
Headers show
Series
  • OpenRISC BFD fixups for Glibc
Related show

Message

Alan Modra via Binutils May 14, 2020, 9 p.m.
Hello,

I am currently working on the glibc port for openrisc and during testing
the glibc testsuite we uncovered several issues with the OpenRISC bfd
implementation relating to TLS relocations.  This series fixes them all.

-Stafford

Stafford Horne (8):
  or1k: Fix static linking when with .rela.got relocations
  or1k: Fix dynamic TLS symbol flag
  or1k: Add TLS mask to handle multiple model access
  or1k: Fix issue with multiple PCREL relocations
  or1k: TLS offset to use tcb size and section alignment
  or1k: refactor: Rename p to sec_relocs
  or1k: refactor: Rename s to sgot and splt
  or1k: Add dynamic flag to tpoff

 bfd/elf32-or1k.c | 368 ++++++++++++++++++++++++++++++-----------------
 1 file changed, 236 insertions(+), 132 deletions(-)

-- 
2.26.2

Comments

Alan Modra via Binutils May 19, 2020, 1:30 p.m. | #1
Hi Stafford,

> Stafford Horne (8):

>   or1k: Fix static linking when with .rela.got relocations

>   or1k: Fix dynamic TLS symbol flag

>   or1k: Add TLS mask to handle multiple model access

>   or1k: Fix issue with multiple PCREL relocations

>   or1k: TLS offset to use tcb size and section alignment

>   or1k: refactor: Rename p to sec_relocs

>   or1k: refactor: Rename s to sgot and splt

>   or1k: Add dynamic flag to tpoff


Patch series approved and applied.  (Sorry for the delay...)

Cheers
  Nick
Alan Modra via Binutils May 19, 2020, 8:42 p.m. | #2
On Tue, May 19, 2020 at 02:30:06PM +0100, Nick Clifton wrote:
> Hi Stafford,

> 

> > Stafford Horne (8):

> >   or1k: Fix static linking when with .rela.got relocations

> >   or1k: Fix dynamic TLS symbol flag

> >   or1k: Add TLS mask to handle multiple model access

> >   or1k: Fix issue with multiple PCREL relocations

> >   or1k: TLS offset to use tcb size and section alignment

> >   or1k: refactor: Rename p to sec_relocs

> >   or1k: refactor: Rename s to sgot and splt

> >   or1k: Add dynamic flag to tpoff

> 

> Patch series approved and applied.  (Sorry for the delay...)


Thank you,

That was not much delay at all.   However, I was about to just apply the set of
patches myself.  Would that have been a problem?

-Stafford
Alan Modra via Binutils May 20, 2020, 10:41 a.m. | #3
Hi Stafford,

> That was not much delay at all.   However, I was about to just apply the set of

> patches myself.  Would that have been a problem?


Not at all.  But I had applied the patches locally, in order to run 
them through my test harness, so it was no effort for me to commit
the patches as well.

Cheers
  Nick