[RFA,00/10] Remove some cleanups from linespec.c

Message ID 20180401163539.15314-1-tom@tromey.com
Headers show
Series
  • Remove some cleanups from linespec.c
Related show

Message

Tom Tromey April 1, 2018, 4:35 p.m.
This series removes many (but not all) cleanups from linespec.c.
Generally the removals are done in the normal way: replacing manual
memory management with a self-managing data structure.

I've tried to make each patch relatively small to make them simpler to
review.

In a few cases the patch required changes outside of linespec.c.

A couple of the patches (at least #2 and #10) are obvious, though of
course it doesn't hurt to read them anyhow.

Regression tested by the buildbot.  I've also built each patch in the
series locally and run it through the gdb.linespec tests, while I was
tracking down the failures described in patch #7 (though of course the
series has changed slightly since then).

Tom

Comments

Simon Marchi April 2, 2018, 2:44 a.m. | #1
On 2018-04-01 12:35 PM, Tom Tromey wrote:
> This series removes many (but not all) cleanups from linespec.c.

> Generally the removals are done in the normal way: replacing manual

> memory management with a self-managing data structure.

> 

> I've tried to make each patch relatively small to make them simpler to

> review.

> 

> In a few cases the patch required changes outside of linespec.c.

> 

> A couple of the patches (at least #2 and #10) are obvious, though of

> course it doesn't hurt to read them anyhow.

> 

> Regression tested by the buildbot.  I've also built each patch in the

> series locally and run it through the gdb.linespec tests, while I was

> tracking down the failures described in patch #7 (though of course the

> series has changed slightly since then).

> 

> Tom

> 


Hi Tom,

The patches I haven't commented on LGTM.

Thanks!

Simon
Tom Tromey April 3, 2018, 10:31 p.m. | #2
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:


Simon> The patches I haven't commented on LGTM.

Thanks.  I've updated the patches and I'll send a new version once I run
it through the buildbot.

Tom