[v2,0/4] GDB fixes for the remote end having gone astray

Message ID alpine.LFD.2.21.1911051509370.13542@redsun52.ssa.fujisawa.hgst.com
Headers show
Series
  • GDB fixes for the remote end having gone astray
Related show

Message

Maciej W. Rozycki Nov. 6, 2019, 8:51 p.m.
Hi Pedro,

> So something like adding a thread_info parameter to

> clear_step_over_info, and then calling clear_step_over_info

> from clear_thread_inferior_resources.  clear_step_over_info

> would only clear the info if the thread matched, or if NULL

> is passed.  Would that work?


 Thank you for your review.

 As issues from software stepping having gone astray seem to have started 
piling up, and with your suggested modifications there is now a dependency 
between the changes, I have decided to make this patch submission a small 
series with 1/4 and 3/4 corresponding to original individual submissions 
and 2/4 and 4/4 being entrely new fixes.

 All these changes were regression-tested with the `x86_64-linux-gnu' 
native target and, now that RISC-V/Linux `gdbserver' I have been working 
on has become usable enough, also the `riscv64-linux-gnu' remote target 
driven by a `x86_64-linux-gnu' host.

 See individual change descriptions and any associated discussions for 
details.

  Maciej

Comments

Maciej W. Rozycki Feb. 17, 2020, 2:07 p.m. | #1
On Wed, 6 Nov 2019, Maciej W. Rozycki wrote:

>  As issues from software stepping having gone astray seem to have started 

> piling up, and with your suggested modifications there is now a dependency 

> between the changes, I have decided to make this patch submission a small 

> series with 1/4 and 3/4 corresponding to original individual submissions 

> and 2/4 and 4/4 being entrely new fixes.


 Ping, where are we with this series:

<https://sourceware.org/ml/gdb-patches/2019-11/msg00191.html>
<https://sourceware.org/ml/gdb-patches/2019-11/msg00192.html>
<https://sourceware.org/ml/gdb-patches/2019-11/msg00193.html>
<https://sourceware.org/ml/gdb-patches/2019-11/msg00194.html>

?  Simon was kind enough (thank you!) to partially review 1-3/4, but I
need a final word on these, and also input on 4/4.

 NB this is my final ping as I need to head to do something else and limit 
distractions.  Patches have been posted, feel free to apply anytime.

  Maciej
Luis Machado Feb. 18, 2020, 10:38 a.m. | #2
On 2/17/20 11:07 AM, Maciej W. Rozycki wrote:
> On Wed, 6 Nov 2019, Maciej W. Rozycki wrote:

> 

>>   As issues from software stepping having gone astray seem to have started

>> piling up, and with your suggested modifications there is now a dependency

>> between the changes, I have decided to make this patch submission a small

>> series with 1/4 and 3/4 corresponding to original individual submissions

>> and 2/4 and 4/4 being entrely new fixes.

> 

>   Ping, where are we with this series:

> 

> <https://sourceware.org/ml/gdb-patches/2019-11/msg00191.html>

> <https://sourceware.org/ml/gdb-patches/2019-11/msg00192.html>

> <https://sourceware.org/ml/gdb-patches/2019-11/msg00193.html>

> <https://sourceware.org/ml/gdb-patches/2019-11/msg00194.html>

> 

> ?  Simon was kind enough (thank you!) to partially review 1-3/4, but I

> need a final word on these, and also input on 4/4.

> 

>   NB this is my final ping as I need to head to do something else and limit

> distractions.  Patches have been posted, feel free to apply anytime.

> 

>    Maciej

> 


I gave this a look and, unfortunately, i don't think i know enough of 
the async* functions purpose to make sure things are correct for all the 
combinations of all-stop/non-stop and async.

I'll give this another look to see if anything comes out next time.
Tom Tromey Feb. 19, 2020, 9:10 p.m. | #3
>>>>> "Maciej" == Maciej W Rozycki <macro@wdc.com> writes:


Maciej>  Ping, where are we with this series:
Maciej> <https://sourceware.org/ml/gdb-patches/2019-11/msg00191.html>
Maciej> <https://sourceware.org/ml/gdb-patches/2019-11/msg00192.html>
Maciej> <https://sourceware.org/ml/gdb-patches/2019-11/msg00193.html>
Maciej> <https://sourceware.org/ml/gdb-patches/2019-11/msg00194.html>

Pedro, could you possibly review these?  They touch on infrun and, IIUC,
on some recent changes related to multi-target.

Tom