[00/15] Another round of TUI refactoring

Message ID 20190814162132.31424-1-tom@tromey.com
Headers show
Series
  • Another round of TUI refactoring
Related show

Message

Tom Tromey Aug. 14, 2019, 4:21 p.m.
Here's another round of TUI refactoring.  This is extracted from a
longer series that I'm submitting in pieces to make it simpler to
read.

Most of these are straightforward.  Patch #8 fixes an existing bug,
see the commentary there for a description.

I tested these on x86-64 Fedora 28, by building each one and running
the gdb.tui tests.

Tom

Comments

Pedro Alves Aug. 15, 2019, 4:29 p.m. | #1
On 8/14/19 5:21 PM, Tom Tromey wrote:
> Here's another round of TUI refactoring.  This is extracted from a

> longer series that I'm submitting in pieces to make it simpler to

> read.

> 

> Most of these are straightforward.  Patch #8 fixes an existing bug,

> see the commentary there for a description.

> 

> I tested these on x86-64 Fedora 28, by building each one and running

> the gdb.tui tests.


I just sent a couple nanocomments, but it all looks good to me.

Thanks,
Pedro Alves
Tom Tromey Aug. 15, 2019, 6:28 p.m. | #2
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:


Pedro> On 8/14/19 5:21 PM, Tom Tromey wrote:
>> Here's another round of TUI refactoring.  This is extracted from a

>> longer series that I'm submitting in pieces to make it simpler to

>> read.

>> 

>> Most of these are straightforward.  Patch #8 fixes an existing bug,

>> see the commentary there for a description.

>> 

>> I tested these on x86-64 Fedora 28, by building each one and running

>> the gdb.tui tests.


Pedro> I just sent a couple nanocomments, but it all looks good to me.

Thanks.  I've fixed those and I'm checking this in now.

Tom